Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Generic variant C071RBTx support#2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 4 commits intostm32duino:mainfromthernstig:C071RBTx
Nov 13, 2024

Conversation

@thernstig
Copy link
Contributor

Fixes#2536

@thernstig
Copy link
ContributorAuthor

@fpistm I am not sure I got the parts right about setting the clock config. I enabled USB as the only peripheral. As you can see by#2557 I am not sure I did it right.

@fpistmfpistm self-requested a reviewNovember 8, 2024 13:50
@fpistmfpistm added the new variantAdd support of new bard labelNov 8, 2024
@fpistmfpistm added this to the2.9.0 milestoneNov 8, 2024
@thernstig
Copy link
ContributorAuthor

thernstig commentedNov 11, 2024•
edited
Loading

@fpistm is this ready for merge? 🙂 I did not get a chance to test it, but you might see if it is correct or not directly with your experience as an ST employee.

Fixesstm32duino#2536Signed-off-by: thernstig <30827238+thernstig@users.noreply.github.com>
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@thernstig
I've squash and apply astyle.
LGTM

thernstig reacted with thumbs up emoji
@fpistmfpistm mentioned this pull requestNov 12, 2024
88 tasks
@thernstig
Copy link
ContributorAuthor

@fpistm I am not sure why the tests fail.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member

@fpistm I am not sure why the tests fail.

In fact new C071xx have a second I2C while previous first C0 don't. So it was managed by the Wire library.
I've made the fix.

@thernstig
Copy link
ContributorAuthor

@fpistm not sure if I can do anything about the failing link, seems unrelated. So hope you can merge 🙂 Thanks for all the help!

@fpistmfpistm merged commit7a2786a intostm32duino:mainNov 13, 2024
24 of 25 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fpistmfpistmfpistm approved these changes

Assignees

No one assigned

Labels

new variantAdd support of new bard

Projects

Milestone

2.9.0

Development

Successfully merging this pull request may close these issues.

Add support for STM32C071Rx

2 participants

@thernstig@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp