- Notifications
You must be signed in to change notification settings - Fork1k
Remove atomicity warning that does not apply to STM32#2502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Taylor Braun-Jones <taylor@braun-jones.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@nocnokneo
Thanks for thePR.
You're right this warning could be removed it is an artifact when the class was created using original Arduino Class.
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Taylor Braun-Jones <taylor@braun-jones.org>
6e60087 intostm32duino:mainUh oh!
There was an error while loading.Please reload this page.
Summary
Removes an atomicity warning in
HardwareSerial.hthat does not apply to (32-bit) STM32. Based on a review onthis response and my own testing, I'm convinced that the atomicity warning and link to an ArduinoCore-avr issue is not relevant.