Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(platform.txt): add default vid/pid definition#2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 2 commits intostm32duino:mainfromfpistm:default_vid_pid
Jul 19, 2024

Conversation

fpistm
Copy link
Member

@fpistmfpistm commentedJul 18, 2024•
edited
Loading

this avoids to add them toboards.txt if not needed.

cmake updated to get the default value fromplatform.txt.

/cc@massonal

This fixes this:
#2445 (comment)

@fpistmfpistm added the fix 🩹Bug fix labelJul 18, 2024
@fpistmfpistm added this to the2.8.1 milestoneJul 18, 2024
@fpistmfpistm mentioned this pull requestJul 18, 2024
this avoids to add them to boards.txt if not needed.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistmfpistm merged commita42bcfe intostm32duino:mainJul 19, 2024
23 checks passed
@fpistmfpistm deleted the default_vid_pid branchJuly 19, 2024 07:16
Copy link
Contributor

@massonalmassonal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The comment at the top ofplatformtxt_filter is now outdated. It needs to mention this new policy wrt vid/pid.

fpistm reacted with laugh emoji
@fpistm
Copy link
MemberAuthor

The comment at the top ofplatformtxt_filter is now outdated. It needs to mention this new policy wrt vid/pid.

ecdf6af

massonal reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@massonalmassonalmassonal left review comments

Assignees
No one assigned
Labels
fix 🩹Bug fix
Projects
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.

2 participants
@fpistm@massonal
[8]ページ先頭
©2009-2025 Movatter.jp