- Notifications
You must be signed in to change notification settings - Fork1k
Added RAK3172T Variant#2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Same as RAK3172 except TCXO is enabled.Signed-off-by: Nico Maas <mail@nico-maas.de>Co-Authored-by: Frederic Pillon <frederic.pillon@st.com>
Member
fpistm commentedJul 15, 2024
Hi@nmaas87 |
fpistm approved these changesJul 15, 2024
Member
fpistm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding Support for RAK3217T, shouldclose#2162 andstm32duino/STM32LoRaWAN#34 - RAK3217 was already available, RAK3217T uses a TCXO which needed to be enabled in the variant files so that examples with STM32LoRaWAN works.
This PR fixes/implements the followingbugs/features
Explain themotivation for making this change. What existing problem does the pull request solve?
Needed to use the RAK3172T myself and wanted the support to be available to all users.
Validation