Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add variant: Generic H503KBU#2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 2 commits intostm32duino:mainfromdojyorin:variant-h503kbu
Jul 9, 2024

Conversation

dojyorin
Copy link
Contributor

@dojyorindojyorin commentedJul 6, 2024•
edited by fpistm
Loading

I'm sorry for inconvenience caused with PR:Nucleo-H503RB.
Could you please make sure added and modified code?

I set clock configuration in STM32CubeMX as described on Wiki, but peripheral configuration were not present in code.
(e.g.PeriphClkInitStruct.UsbClockSelection = RCC_USBCLKSOURCE_HSI48)
Looking at CubeMX clock configuration GUI, for example, USB uses HSI48 by default, so does that mean no additional configurations are required?

Summary

This PR implements the followingfeatures

  • New variant: Generic STM32H503KBU

* add board definition.* copy ldscript.* change name.* copy clock config.* add generic clock.* variable size.* add support list.
@dojyorindojyorin changed the titleAdd variant: H503KBUAdd variant: Generic H503KBUJul 6, 2024
@fpistmfpistm added the new variantAdd support of new bard labelJul 8, 2024
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor typo to fix and it is ok for me.
About Periphjeral clock config, no need to specify it as HSI48 is the default entry.

Accept version fix.Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Kazuki Ota <ota_droid@live.jp>
@dojyorin
Copy link
ContributorAuthor

About Periphjeral clock config, no need to specify it as HSI48 is the default entry.

Thank you for teaching me.
Version fix suggestion was accepted.

@dojyorindojyorin requested a review fromfpistmJuly 8, 2024 17:58
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@fpistmfpistm added this to the2.8.1 milestoneJul 9, 2024
@fpistmfpistm merged commit0f1ee4d intostm32duino:mainJul 9, 2024
24 checks passed
@dojyorindojyorin deleted the variant-h503kbu branchJuly 10, 2024 17:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

Assignees
No one assigned
Labels
new variantAdd support of new bard
Projects
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.

2 participants
@dojyorin@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp