Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor: move several sources as built-in library#2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 3 commits intostm32duino:mainfromfpistm:refactor_code
Jun 20, 2024

Conversation

@fpistm
Copy link
Member

Several reasons:

  • Avoid licenses conflict
  • Improve build time on windows
  • 1 feature per library

@fpistmfpistm added enhancementNew feature or request arduino compatibility fix 🩹Bug fix labelsJun 19, 2024
@fpistmfpistm added this to the2.8.0 milestoneJun 19, 2024
@fpistmfpistmforce-pushed therefactor_code branch 2 times, most recently fromf30df88 to349e313CompareJune 19, 2024 14:14
Copy link

@mathieuchopstmmathieuchopstm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!
A few comments:

belong to sources.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Including OpenAMP.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
It could propbaly be splitted in 3 libraries:- USBDevice: base support- USBDCDC- USBDHIDSigned-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistmfpistm merged commita3e468a intostm32duino:mainJun 20, 2024
@fpistmfpistm deleted the refactor_code branchJune 20, 2024 06:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mathieuchopstmmathieuchopstmmathieuchopstm left review comments

Assignees

No one assigned

Labels

arduino compatibilityenhancementNew feature or requestfix 🩹Bug fix

Projects

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@fpistm@mathieuchopstm
[8]ページ先頭
©2009-2025 Movatter.jp