Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Blues Cygnet#2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 3 commits intostm32duino:mainfromzfields:cygnet
Jun 14, 2024
Merged

feat: Blues Cygnet#2399

fpistm merged 3 commits intostm32duino:mainfromzfields:cygnet
Jun 14, 2024

Conversation

zfields
Copy link
Contributor

@zfieldszfields commentedJun 12, 2024•
edited
Loading

Refactor Blues Wireless to Blues
Define Cygnet
Improvements to Swan

The bad link (in the checks), is our reserved page for this product.

@zfields
Copy link
ContributorAuthor

This migrates the Ray's original Cygnet work to the STM32L433CCT6, and incorporates many suggestions from@fpistm's code review.

@fpistm Can you please sanity check this work. This is my first time making significant modifications to the board definition.

@fpistmfpistm self-requested a reviewJune 13, 2024 06:48
@fpistmfpistm added the new variantAdd support of new bard labelJun 13, 2024
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@zfields
Thanks for the updated PR.
Just on remarks about the link even if reserved on your side I would prefer add it when really available to avoid further support because one link does not exist and not related to other PR.

zfields reacted with thumbs up emoji
@zfields
Copy link
ContributorAuthor

@fpistm I've adopted your change. 👍 Thank you for your help! ❤️

@fpistmfpistm self-requested a reviewJune 14, 2024 06:56
@fpistmfpistm added this to the2.8.0 milestoneJun 14, 2024
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@zfields
I've squash some commits to be more clean.
LGTM

zfields reacted with heart emoji
@fpistmfpistm merged commit7efecbf intostm32duino:mainJun 14, 2024
24 checks passed
@zfieldszfields deleted the cygnet branchJune 14, 2024 14:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

Assignees
No one assigned
Labels
new variantAdd support of new bard
Projects
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

2 participants
@zfields@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp