I added this variant and tested everyhing works like expected for STM32H7B0VBT. I tested specificly for STM32H7B0VBT in my project but I added the other boards like in Add a new vatiant wiki. Please update the wiki the memory part should not updated like in wiki otherwise it is not working because of cortex m7 it need partial memories.

STM32H7B0VBTX board variant added to the boards

b92ae53

I added this variant and tested everyhing works like expected for STM32H7B0VBT. I tested specificly for STM32H7B0VBT in my project but I added the other boards like in Add a new vatiant wiki. Please update the wiki the memory part should not updated like in wiki otherwise it is not working because of cortex m7 it need partial memories.

fpistm requested changes

Jun 3, 2024

View reviewed changes

Copy link

Member

fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@Aurentiaco35
Thanks for the PR.
About the Size in linker script, it should simply refers to the one defined in the boards.txt.
Then all generic variants have the correct value and can benefit of the offset feature.
In the boards.txt, the value of the RAM have to be updated to match the correct size used for Arduino, mainly when it is not contiguous.
The wiki, show a simple use case where only 1 FLASH and 1 RAM section are described.
Even the linker script can be updated, for example when RAM's are contiguous then only one with the full size can be defined.

README.md OutdatedShow resolvedHide resolved

variants/STM32H7xx/H7A3V(G-I)(H-T)_H7B0VBT_H7B3VI(H-T)/ldscript.ld OutdatedShow resolvedHide resolved

boards.txt OutdatedShow resolvedHide resolved

variants/STM32H7xx/H7A3V(G-I)(H-T)_H7B0VBT_H7B3VI(H-T)/generic_clock.c OutdatedShow resolvedHide resolved

fpistm added the new variantAdd support of new bard label

Jun 3, 2024

fpistm added this to the2.8.0 milestone

Jun 3, 2024

Aurentiaco35and others added12 commits

June 3, 2024 16:33

Update README.md

cc8f5e5

Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Update variants/STM32H7xx/H7A3V(G-I)(H-T)_H7B0VBT_H7B3VI(H-T)/ldscrip…

c1bd922

…t.ldCo-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Update variants/STM32H7xx/H7A3V(G-I)(H-T)_H7B0VBT_H7B3VI(H-T)/ldscrip…

4387668

…t.ldCo-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Update boards.txt

afe24e8

Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Update boards.txt

d5569f8

Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Update boards.txt

93f7f5a

Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Update boards.txt

dda2326

Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Update boards.txt

2fa7b17

Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Update variants/STM32H7xx/H7A3V(G-I)(H-T)_H7B0VBT_H7B3VI(H-T)/generic…

62a785e

…_clock.cCo-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Update variants/STM32H7xx/H7A3V(G-I)(H-T)_H7B0VBT_H7B3VI(H-T)/generic…

71b9160

…_clock.cCo-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Update variants/STM32H7xx/H7A3V(G-I)(H-T)_H7B0VBT_H7B3VI(H-T)/generic…

034d8c2

…_clock.cCo-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Update boards.txt

62be59b

Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Copy link

ContributorAuthor

Aurentiaco35 commentedJun 3, 2024

I commited these suggestions. Thank you for your help.

Aurentiaco35 requested a review fromfpistm

June 4, 2024 06:51

Update generic_clock.c

6f4b0c1

I added space character as it in the test error Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

fpistm approved these changes

Jun 4, 2024

View reviewed changes

Copy link

Member

fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link

ContributorAuthor

Aurentiaco35 commentedJun 4, 2024

I couldn't understand in that linkintor which part should I update?

Copy link

Member

fpistm commentedJun 4, 2024

Nothing. The url probably down during the test.

Copy link

ContributorAuthor

Aurentiaco35 commentedJun 4, 2024•
edited
Loading

So what should I do next is there anything that I can do? When you are going to merge and we will see these boards in IDE?

fpistm requested changes

Jun 4, 2024

View reviewed changes

Copy link

Member

fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please fix the last issue and squash all commit in one.

boards.txt OutdatedShow resolvedHide resolved

Copy link

Member

fpistm commentedJun 4, 2024

And don't worry, I will merge it when last changes performed then it will be available within next release 2.8.0.

Update boards.txt

8738d2f

Signed-off-by: Aurentiaco35 <140486360+Aurentiaco35@users.noreply.github.com>

Copy link

ContributorAuthor

Aurentiaco35 commentedJun 4, 2024

Thank you for your info. And sorry about it. I missed that now I commit it. Thank you again.

fpistm approved these changes

Jun 4, 2024

View reviewed changes

Copy link

Member

fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

fpistm merged commit483c954 intostm32duino:main

Jun 5, 2024

24 checks passed

Labels

new variant

Add support of new bard

2 participants

Movatterモバイル変換

STM32H7B0VBTX board variant added to the boards#2387

STM32H7B0VBTX board variant added to the boards#2387

Uh oh!

Conversation

Aurentiaco35 commentedJun 3, 2024

Uh oh!

fpistm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Aurentiaco35 commentedJun 3, 2024

Uh oh!

fpistm left a comment

Choose a reason for hiding this comment

Uh oh!

Aurentiaco35 commentedJun 4, 2024

Uh oh!

fpistm commentedJun 4, 2024

Uh oh!

Aurentiaco35 commentedJun 4, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

fpistm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fpistm commentedJun 4, 2024

Uh oh!

Aurentiaco35 commentedJun 4, 2024

Uh oh!

fpistm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Aurentiaco35 commentedJun 4, 2024•
edited
Loading