Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Added Support for ELV-BM-TRX1#2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 2 commits intostm32duino:mainfromELV-Elektronik-AG:main
May 27, 2024
Merged

Conversation

ELV-Elektronik-AG
Copy link

@ELV-Elektronik-AGELV-Elektronik-AG commentedMay 22, 2024•
edited by fpistm
Loading

  • Added Support for the ELV-BM-TRX1

The ELV Modular System is a great fit for the stm32duino library

Validation

Github Actions have passed, a working sketch is

#include "STM32LowPower.h"void setup() {  pinMode(LED_BUILTIN, OUTPUT);  // Configure low power  LowPower.begin();}void loop() {  digitalWrite(LED_BUILTIN, HIGH);  LowPower.deepSleep(1000);  digitalWrite(LED_BUILTIN, LOW);  LowPower.deepSleep(1000);}

@fpistmfpistm added the new variantAdd support of new bard labelMay 23, 2024
@fpistmfpistm added this to the2.8.0 milestoneMay 23, 2024
@fpistmfpistm self-requested a reviewMay 23, 2024 08:40
@fpistm
Copy link
Member

Hi@ELV-Elektronik-AG
I've made some change on your PR. (Note: as a good practice I advise to not use main branch name for a PR).
I've removed all commented code, fix some change in the README.d not link to the PR and fixed the boards.txt.
Anyway I've some other questions I will raised in the review.

@fpistmfpistm requested a review fromfabry1992May 23, 2024 12:50
@fpistm
Copy link
Member

@fabry1992
you can't approve it as no change has been done since my last review.
Let me update with your input and then you can test on your side.

Stephan Fabryand others added2 commitsMay 23, 2024 16:33
Signed-off-by: Stephan Fabry <stephan.fabry@eq-3.com>Co-Authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member

fpistm commentedMay 23, 2024•
edited
Loading

@ELV-Elektronik-AG,@fabry1992
I've made the full update, forced pushed on your branch and resolved all conversations.
Please fetch your main branch to get the latest update and check if it is ok.

@fpistmfpistm requested review fromfabry1992 andfpistmMay 23, 2024 14:39
Copy link

@fabry1992fabry1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I hvae tested The pins and everything works. Thanks so much for your work and im sorry to be suc a nuisance

@fpistm
Copy link
Member

Hi@fabry1992

I hvae tested The pins and everything works. Thanks so much for your work and im sorry to be suc a nuisance

No worry. Thanks for the test. From my side it is ok to merge. Are you ok?

@fpistmfpistm merged commit36fb912 intostm32duino:mainMay 27, 2024
24 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

@fabry1992fabry1992fabry1992 approved these changes

Assignees
No one assigned
Labels
new variantAdd support of new bard
Projects
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

3 participants
@ELV-Elektronik-AG@fpistm@fabry1992
[8]ページ先頭
©2009-2025 Movatter.jp