Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

add "toString" function with IPAddress#2306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 2 commits intostm32duino:mainfromVirensCn:main
Mar 26, 2024
Merged

Conversation

VirensCn
Copy link
Contributor

@VirensCnVirensCn commentedMar 17, 2024•
edited by fpistm
Loading

This PR implements the followingfeatures

  • add toString function with IPAddress

EnhancementIPAddress is missing the toString function interface？

@fpistm
Copy link
Member

Hi@VirensCn
Thanks for the PR.
It seems you used implementation done in other core (esp32 ?).
I've reworked your PR to be aligned (as much as possible) to official Arduino Core API:
https://github.com/arduino/ArduinoCore-API

@fpistmfpistm added arduino compatibility enhancementNew feature or request labelsMar 18, 2024
@fpistmfpistm added this to the2.8.0 milestoneMar 18, 2024
@VirensCn
Copy link
ContributorAuthor

I think I should submit the toString function for IPV4 first

@VirensCnVirensCn reopened thisMar 25, 2024
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@fpistmfpistm merged commit79579d7 intostm32duino:mainMar 26, 2024
tadtruex pushed a commit to TadAtThayer/Arduino_Core_STM32 that referenced this pull requestApr 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

Assignees
No one assigned
Labels
arduino compatibilityenhancementNew feature or request
Projects
Milestone
2.8.0
Development

Successfully merging this pull request may close these issues.

IPAddress is missing the toString function interface？
2 participants
@VirensCn@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp