- Notifications
You must be signed in to change notification settings - Fork1k
HardwareSerial's flush() method to override the method of the base class Print#2254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
fpistm approved these changesJan 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Thanls@ilolis
Tested with: |
tadtruex pushed a commit to TadAtThayer/Arduino_Core_STM32 that referenced this pull requestApr 23, 2024
…ass Print (stm32duino#2254)* add flush() method to HardwareSerial* remove default argument
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR addresses the followingbugs/features
void flush()method not being overridden by derivative HardwareSerial'svoid flush(uint32_t timeout = 0)method.The base class Printdefines
void flush(), while the derivative HardwareSerial definesvoid flush(uint32_t timeout = 0). The issue was that when using the base class instance pointer, the virtual function of the derivative was not being called. This PR resolves this.I might be missing something since I am new to this project, so please feel free to correct me :)