- Notifications
You must be signed in to change notification settings - Fork1k
feat(spi): add transfer api with tx and rx buffer#2206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
SPI_TRANSFER_TIMEOUT is always passed as an argumentwhile it is a constant definition.So simply function call and check.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Fixesstm32duino#2205Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
PR is now ready. Thanks@greiman. Results of bench sketch: -### 2.6.0-Sketch uses 41400 bytes (3%) of program storage space. Maximum is 1048576 bytes.-Global variables use 3296 bytes (3%) of dynamic memory, leaving 95008 bytes for local variables. Maximum is 98304 bytes.+### 2.7.1+Sketch uses 40224 bytes (3%) of program storage space. Maximum is 1048576 bytes.+Global variables use 3248 bytes (3%) of dynamic memory, leaving 95056 bytes for local variables. Maximum is 98304 bytes.-FreeStack: 94912+FreeStack: 94960 Type is FAT16 Card size: 1.98 GB (GB = 1E9 bytes)@@ -20,15 +20,15 @@ write speed and latency speed,max,min,avg KB/Sec,usec,usec,usec-1126.13,154491,406,453-1089.56,154378,406,468+1138.69,154066,401,448+1100.11,155705,401,463 Starting read test, please wait. read speed and latency speed,max,min,avg KB/Sec,usec,usec,usec-1143.64,458,444,445-1143.90,457,445,445+1222.79,428,416,417+1222.49,428,416,417 Done |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#2205
For ref:arduino/ArduinoCore-API#189
Tested with SdFat patched with: