Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add support for setting the channel input filter#2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 3 commits intostm32duino:mainfromdberlin:main
Sep 27, 2023

Conversation

dberlin
Copy link
Contributor

Pull Request template

Please, Make sure that your PR is not a duplicate.
Search among thePull request before creating one.

IMPORTANT: Please review theCONTRIBUTING.md file for detailed contributing guidelines.

Thanks for submitting a pull request.
Please provide enough information so that others can review your pull request:

Summary

This PR implements the followingfeature

  • Support for input channel filtering in HardwareTimer

Currently, HardwareTimer sets the input channel filter to none, any time the mode of the timer is set.
This PR enables the input filter to be set along with the mode.

It is possible to enable setting the input filter separately from the mode if wanted.

Validation

Tested with a waveform generator vs sketch outputting pulse widths + levels

@fpistmfpistm added the enhancementNew feature or request labelSep 23, 2023
@fpistm
Copy link
Member

Hi@dberlin
thanks for this PR.
Could you also share your test sketch, please ?

@dberlin
Copy link
ContributorAuthor

dberlin commentedSep 26, 2023•
edited
Loading

Hi@dberlin thanks for this PR. Could you also share your test sketch, please ?

Sure.

Removing a whole bunch, it's attached:
Note - i use platformio, and define the c++ standard flag to gnu++17.
The sketch also uses the streaming library, but this could be easily changed.

I parse the pulses out and verify the results.
main.cpp.txt

Copy link
Contributor

@ABOSTMABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@dberlin
LGTM

@fpistmfpistm added this to the2.7.0 milestoneSep 26, 2023
@fpistmfpistm merged commit61a1680 intostm32duino:mainSep 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ABOSTMABOSTMABOSTM approved these changes

Assignees

@ABOSTMABOSTM

Labels
enhancementNew feature or request
Projects
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

3 participants
@dberlin@fpistm@ABOSTM
[8]ページ先頭
©2009-2025 Movatter.jp