Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add variant: add support for generic F446Z(C-E)(H-J-T) and Nucleo-F446ZE#2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 2 commits intostm32duino:mainfromCMGeldenhuys:stm32f446ze-support
Aug 31, 2023

Conversation

CMGeldenhuys
Copy link
Contributor

Summary

This PR adds support for the STM32F446Z(C-E)(H-J-T) variants as well as the Nucleo-F446ZE board. The code has been tested on a Nucleo-F446ZE.

Closing issues

Closes#1487 (Already marked as closed, but no support was added, from what I can see.)

@fpistmfpistm self-requested a reviewAugust 28, 2023 09:45
@fpistmfpistm added the new variantAdd support of new bard labelAug 28, 2023
@fpistmfpistm added this to the2.7.0 milestoneAug 28, 2023
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@CMGeldenhuys
Thanks for this PR.
Sorry for the delay, I was on vacation.
First quick review. Let's CI run to see if any errors occurs.

@CMGeldenhuys
Copy link
ContributorAuthor

Hi@fpistm, I've updated the README as requested and squashed the changes into the old commits.

fpistm reacted with thumbs up emoji

@fpistm
Copy link
Member

Thanks@CMGeldenhuys for this PR and the nice work.
I've just made some small fixes and for me it LGTM.

CMGeldenhuys reacted with thumbs up emoji

@fpistmfpistm linked an issueAug 30, 2023 that may beclosed by this pull request
@fpistmfpistm mentioned this pull requestAug 30, 2023
85 tasks
@fpistmfpistm merged commitd07fcaf intostm32duino:mainAug 31, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

Assignees
No one assigned
Labels
new variantAdd support of new bard
Projects
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

Pls add STM32F446ZE to supported controllers. Readme.md should be updated to show support for variant F446ZE
2 participants
@CMGeldenhuys@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp