Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: update to CMSIS 5.9.0#2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 4 commits intostm32duino:mainfromfpistm:CMSIS_5.9.0
Aug 10, 2023
Merged

Conversation

fpistm
Copy link
Member

No more DSP libraries.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistmfpistm added the enhancementNew feature or request labelAug 9, 2023
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
MemberAuthor

Hi@valeros
Hope you are fine. I've updated the cmsis version but it seems pio does not like it. Any thoughts on this?

@valeros
Copy link
Contributor

Hi@fpistm, thanks for pinging. It seems that the CMSIS package is not updated properly. I'm curious how you handle such updates. I've found theentrypoint.sh script that does some manipulations like downloading a CMSIS package, but I don't see any other actions besides extracting the CMSIS package to the home folder of the CI runner. Am I missing something?

@fpistm
Copy link
MemberAuthor

It seems it is properly downloaded. With arduino, no issue. The file is properly built. Maybe GH action cache issue, but seems not the case.

@valeros
Copy link
Contributor

It seems it is properly downloaded. With arduino, no issue. The file is properly built. Maybe GH action cache issue, but seems not the case.

I'm afraid it's not enough to simply extract the CMSIS package in the core folder, PlatformIO won't see this update as the CMSIS is a standalone package in the PlatformIO ecosystem. I see here two ways how to handle this:

  1. The easiest approach is to publish the new CMSIS 5.9.0 to the PlatformIO Registry and then dynamically replace the version field in theentrypoint.sh. A single drawback is that we'll lose the ability of replacing the CMSIS package with arbitrary versions directly from thehttps://github.com/stm32duino/ArduinoModule-CMSIS
  2. We keep the current workflow with downloading the CMSIS package fromhttps://github.com/stm32duino/ArduinoModule-CMSIS, but introduce some additional logic that will properly substitute the already downloaded CMSIS with a new one.

Let me know, what's more suitable for you.

@fpistm
Copy link
MemberAuthor

Hi@valeros
OK understood. I thought it already uses the downloaded one. Seems this download was not useful 😉
So I guess option 2 is the best way else we will got this issue again in the next update.

@fpistmfpistm merged commitac91c49 intostm32duino:mainAug 10, 2023
@fpistmfpistm deleted the CMSIS_5.9.0 branchAugust 10, 2023 13:49
@fpistm
Copy link
MemberAuthor

PIO build will be managed later.

@fpistmfpistm added this to the2.7.0 milestoneAug 10, 2023
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull requestAug 10, 2023
Sincestm32duino#2099, pio build failed as it does not used thespecified CMSIS version.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistmfpistm mentioned this pull requestAug 10, 2023
fpistm added a commit that referenced this pull requestAug 10, 2023
Since#2099, pio build failed as it does not used thespecified CMSIS version.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

2 participants
@fpistm@valeros

[8]ページ先頭

©2009-2025 Movatter.jp