Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add variant: NUCLEO-H503RB.#2092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
dojyorin wants to merge2 commits intostm32duino:mainfromdojyorin:feat-nucleo-h503rb
Closed

Add variant: NUCLEO-H503RB.#2092

dojyorin wants to merge2 commits intostm32duino:mainfromdojyorin:feat-nucleo-h503rb

Conversation

@dojyorin
Copy link
Contributor

@dojyorindojyorin commentedAug 5, 2023•
edited
Loading

Add variant: NUCLEO-H503RB

Summary

This PR fixes/implements the followingbugs/features

@fpistm feat addsSTM32H5 core implementation and NUCLEO-H563ZI support (That was really great help! Thank you!), but variant support is still lacking.

This time, I'll add new H5 NUCLEO board NUCLEO-H503RB with this pull request.
Related to#722 (comment) and#2091

Progress

There's still some work to do.

Basically implementation of NUCLEO-H563ZI is used reference.

I'm new to STM32, so excuse me if I'm doing something wrong.
I would like to discuss with everyone and produce good results.

@fpistmfpistm self-requested a reviewAugust 5, 2023 18:12
@fpistmfpistm added the new variantAdd support of new bard labelAug 5, 2023
@fpistmfpistm added this to the2.7.0 milestoneAug 5, 2023
@fpistm
Copy link
Member

Thanks for squashing. Anyway simply force update on the same branch will avoid creating new PR. :wink : Let ci run to check this PR first.

dojyorin reacted with eyes emoji

Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

First thanks for this PR.
In addition to my comments, could you add the generic and the Nucleo in the README.md and also declare them to the boards.txt.
Finally, split in 2 commit, 1 for the generic addition and one for the dedicated Nucleo board.

You can refers to this PR as example:
#1859

@dojyorin
Copy link
ContributorAuthor

Thank you for detailed explanation, it really helped me.
It was a great reference when I wanted to add other boards in the future.

For the time being, I've fixed the part you told me, so I'll commit it.

@dojyorindojyorin requested a review fromfpistmAugust 15, 2023 07:50
@dojyorin
Copy link
ContributorAuthor

The Arduino pinout only goes up toD15/A5, but the MCU has more pins.
I wasn't sure what rules to define the "surplusD16/A6 and beyond" pins.

@fpistm
Copy link
Member

fpistm commentedAug 28, 2023•
edited
Loading

Hi@dojyorin
I've reworked and fixed your PR.
https://github.com/fpistm/Arduino_Core_STM32/tree/feat-nucleo-h503rb
Could you try it and force update to your branch. Thanks

@fpistmfpistm added the abandonedNo more work on this labelAug 30, 2023
@fpistmfpistm closed thisAug 30, 2023
@dojyorindojyorin deleted the feat-nucleo-h503rb branchSeptember 11, 2023 15:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fpistmfpistmAwaiting requested review from fpistm

Assignees

No one assigned

Labels

abandonedNo more work on thisnew variantAdd support of new bard

Projects

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dojyorin@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp