- Notifications
You must be signed in to change notification settings - Fork1k
make cmake work on macos#2060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nathantsoi commentedJul 10, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
One caveat here. I found that thectags for macOS on the Arduino github releases page is not 64-bit, however, the ctags binary distributed in the Arduino app is... so I also had to: I'm not sure if a 64-bit ctags binary is available outside of the Arduino installer, but this would be a better solution. |
massonal commentedJul 10, 2023
Fromcmake_host_system_information, redirecting toCMAKE_HOST_SYSTEM_NAME:
Did you really observe the value "macOS"?! (That's fine, but it would mean the docs are confusing...) As for the caveat you outline:ctags-5.8-arduino11-x86_64-apple-darwin.zip is what you're looking for, no? Or do you mean they packaged a 32-bits app with a 64-bits name? |
fpistm commentedJul 10, 2023
As an extra information: which Mac-OS version you used ? |
nathantsoi commentedJul 10, 2023
MacOS version is Ventura And yes,@massonal, thex86_64 zip contains an i386 executable: vs. The correct, 64-bit version included with the arduino app: |
fpistm commentedJul 10, 2023
@nathantsoi you don't answer this question from@massonal
On our side a MacBook Pro with Monterey v12.6.1 is used to validate and result of |
nathantsoi commentedJul 10, 2023
Correct, I get the string (Snippet from Results in: |
massonal commentedJul 10, 2023
Thanks for the confirmation@nathantsoi. As for the issue you have with ctags, do you see any functional impact from the 32-bits version? My final take on this PR: it does not introduce anybug, so it may be merged safely. |
massonal left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This code is bug-less and harm-less.
Merging it is a matter of policy.
nathantsoi commentedJul 10, 2023
Re. the macOS string, I'll open a ticket w/ cmake. Re. ctags, I should clarify that the 32-bit version of ctags will not run on macOS 13.x. Using thehttps://github.com/arduino/ctags binary results in this error: Hence the need to copy in the 64-bit version from the Arduino.app Perhaps this can be noted in the cmake setup documentation for now? I am happy to do this if you would like. |
nathantsoi commentedJul 10, 2023
Actually,@massonal, I just checked And this does yield the documented result: Note, this is different from the snippets in |
massonal commentedJul 10, 2023
That last item with
Definitely mention that in the ticket you write to CMake! |
fpistm commentedJul 11, 2023
Feel free to submit a PR for that 😉 |
Summary
cmake's downloads (ctags and toolchain) were not working on macos.
Validation
tested on mac os 13.4.1 and cmake 3.26.4