Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

variants(C0): add generic C011D6, C011F(4-6)(P-U) and C031F(4-6)P#2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 1 commit intostm32duino:mainfromfpistm:STM32C011D6
Jun 29, 2023

Conversation

fpistm
Copy link
Member

Base for#1995.

/CC@honnet

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistmfpistm added the new variantAdd support of new bard labelJun 29, 2023
@fpistmfpistm added this to the2.6.0 milestoneJun 29, 2023
@fpistmfpistm merged commit292819f intostm32duino:mainJun 29, 2023
@fpistmfpistm deleted the STM32C011D6 branchJune 29, 2023 13:29
@honnet
Copy link
Contributor

Very cool!
Now I understand better what was wrong in myoriginal pull request, hopefully it will help me improve my future PRs, thanks a lot!


PS: There's a last question if I may:

I had toremove the "WEAK" attribute for SystemClock_Config(), otherwise some of these parameters* were overwritten.

=> Could it be because it was (incorrectly) in variant_generic.cpp instead ofgeneric_clock.c?

*I think it was the Clock source or pre-scaler.

@fpistm
Copy link
MemberAuthor

The function have to be WEAK to be able to overwrite it at sketch level that's all.

@honnet
Copy link
Contributor

OK! Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new variantAdd support of new bard
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

2 participants
@fpistm@honnet

[8]ページ先頭

©2009-2025 Movatter.jp