Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add MicroMod STM32WB5MMG. Move MicroMod STM32F405 under SparkFun Boards file.#2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 15 commits intostm32duino:mainfromSFE-Brudnerd:last_working_version
Jun 14, 2023

Conversation

SFE-Brudnerd
Copy link
Contributor

@SFE-BrudnerdSFE-Brudnerd commentedJun 7, 2023•
edited
Loading

Summary

Adds the MicroMod Processor Board - STM32WB5MMG board files.

Consolidates the SparkFun STM32 products under one menu.

This PR fixes/implements the followingfeatures

  • Adds the MicroMod Processor Board - STM32WB5MMG

Explain themotivation for making this change. What existing problem does the pull request solve?

The motivation of the change is to add Arduino support for an upcoming board release.

Validation

  • Ensure CI build is passed. ✅

Code formatting

  • Ensure AStyle check is passed thanks CI ✅

Missing Pin C13.Set correct UART TX/RX.Add LPUART.Re-add ifdef guards for TIM.Add Serial Hardware Open
Bring boards.txt file changes to current release standards.Move F405 MMPB to SFE category in boards.txt.Update README.md for SFE boards.Ran cmake_updater_hook.py only allowing changes that affect SFE productsAdded STM32WB5MMG MMPB to platformio boards_remap.json
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@SFE-Brudnerd
Thanks for this PR.
You can find here my first remarks about this PR. I will deeply check later.

@fpistmfpistm added the new variantAdd support of new bard labelJun 8, 2023
@fpistmfpistm added this to the2.6.0 milestoneJun 8, 2023
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
@SFE-Brudnerd
Copy link
ContributorAuthor

Hey@fpistm, when I was running the arduino-cli workflow, I receivedthis error, from what I'm reading this is an issue outside of the changes I've made. Is this expected?

@SFE-BrudnerdSFE-Brudnerd marked this pull request as draftJune 8, 2023 17:18
@fpistm
Copy link
Member

No. It seems your changes brings issue with {} issue. Will check that.

Add space to ToC that was mistakenly removed.Readded pipe that was mistakenly removed.
@fpistm
Copy link
Member

Let's CI run to have a first result. 😉

Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Build issue comes from the flash_offset not defined in boards.txt

SFE-Brudnerdand others added4 commitsJune 9, 2023 08:53
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
@SFE-BrudnerdSFE-Brudnerd marked this pull request as ready for reviewJune 9, 2023 16:20
@fpistm
Copy link
Member

You didn't try to build before? So you didn't make any tests with the board?

@SFE-Brudnerd
Copy link
ContributorAuthor

I did a fair bit of testing before I pulled the upstream in, I realized that I didn't test afterwards.

@SFE-BrudnerdSFE-Brudnerd requested a review fromfpistmJune 9, 2023 17:12
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

While the link is not valid, it could not be listed here for security purpose.

Co-authored-by: Frederic Pillon <frederic.pillon@st.com>Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member

@SFE-Brudnerd
FYI, I've made a little fix on theSERIAL_UART_INSTANCEwhich is 1 forUSART1. 101 is forLPUART1.

SFE-Brudnerd reacted with hooray emoji

@fpistmfpistm merged commitbe83b9b intostm32duino:mainJun 14, 2023
@SFE-Brudnerd
Copy link
ContributorAuthor

Works for me, thanks!

@SFE-BrudnerdSFE-Brudnerd mentioned this pull requestJun 29, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

Assignees
No one assigned
Labels
new variantAdd support of new bard
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

2 participants
@SFE-Brudnerd@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp