Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add RAK3172 module#2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 1 commit intostm32duino:mainfromOliv4945:variant/RAK3172-Module
Apr 17, 2023
Merged

Conversation

Oliv4945
Copy link
Contributor

Summary

This PR implements RAK3172 module bases on STM32WLE5CCU

As discussed the LoRaWAN repo (stm32duino/STM32LoRaWAN#13) it is cleaner to add it here.
This is still a draft as I did not update the main Readme because of a question: I created the sectionLoRa modules , but is it correct? If not, should I place it in theLoRa boards instead?

Validation

  • LoRaWAN works on the module. I did not test the other peripherals like SPI or I2C

@fpistm
Copy link
Member

Hi@Oliv4945
Thanks for this contribution.
Please add it to the LoRa section to avoid adding new one. I will review it tomorrow.

@Oliv4945
Copy link
ContributorAuthor

Thanks@fpistm, I moved it.
I put a green heart as the "generic WLE5CC" but I saw that you put yellow on the Seeedstudio's E5 module, so please tell me your policy ;)

fpistm reacted with thumbs up emoji

@fpistmfpistm added the new variantAdd support of new bard labelApr 14, 2023
@fpistmfpistm added this to the2.6.0 milestoneApr 14, 2023
@fpistm
Copy link
Member

Well while the new release including the board is not released I put it in yellow and moved to green when officially released.

Oliv4945 reacted with thumbs up emoji

@fpistmfpistm self-requested a reviewApril 14, 2023 08:55
@Oliv4945
Copy link
ContributorAuthor

Ok, updated

fpistm reacted with rocket emoji

@fpistm
Copy link
Member

fpistm commentedApr 14, 2023•
edited
Loading

Here the patch, if it helps.
Note that you can adapt analog pins if you want as I've defined all possible ones but rename the one as defined by RAK GH repo
patch1.patch

@Oliv4945
Copy link
ContributorAuthor

Wow, thanks@fpistm and sorry for the mistakes. I have been mislead by another document with some other errors that I reported to RAK. I agree with all your changes except for PB5: unless I am using the wrong datasheet there is no ADC
image
Is that correct?

I order to avoid any further error also doubled checked the PIN definition with theirRUI BSP

@fpistm
Copy link
Member

fpistm commentedApr 14, 2023•
edited
Loading

Oups, you are right. PB5 has no ADC as defined in the generic:

#definePA10 PIN_A0
#definePA11 PIN_A1
#definePA12 PIN_A2
#definePA13 PIN_A3
#definePA14 PIN_A4
#definePA15 PIN_A5
#definePB0 16
#definePB2 PIN_A6
#definePB3 PIN_A7
#definePB4 PIN_A8
#definePB5 20

Please fix.
I've updated my review suggestions. Hope I do no another mistake 😕
And my patch

@fpistm
Copy link
Member

Could you rebase on top of the main as it seems there are some conflits.

@Oliv4945
Copy link
ContributorAuthor

Thanks, I applied your patch

@Oliv4945
Copy link
ContributorAuthor

Could you rebase on top of the main as it seems there are some conflits.

Ok, I just did but I did not saw any conflicts

@fpistm
Copy link
Member

You don't rebase you do a merge.
Conflict is always here:

This branch cannot be rebased due to conflicts

Oliv4945 reacted with thumbs up emoji

@Oliv4945Oliv4945force-pushed thevariant/RAK3172-Module branch from029f9d6 to3874dacCompareApril 16, 2023 06:24
@Oliv4945
Copy link
ContributorAuthor

Right I am more used to merge sorry :)
I just rebased and squashed the branch to have cleaner history.

fpistm reacted with thumbs up emoji

Copy link
Member

@fpistmfpistm left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@Oliv4945
LGTM. Nice contribution.
I've not tested as I don't have the RAK module but variant is correctly defined.

Oliv4945 reacted with heart emoji
@fpistmfpistm merged commitf76926c intostm32duino:mainApr 17, 2023
@Oliv4945Oliv4945 deleted the variant/RAK3172-Module branchApril 17, 2023 09:16
@fpistmfpistm mentioned this pull requestJul 15, 2024
85 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

Assignees
No one assigned
Labels
new variantAdd support of new bard
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

2 participants
@Oliv4945@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp