stm32duino/Arduino_Core_STM32Public

NotificationsYou must be signed in to change notification settings
Fork1k
Star3.2k

Add RAK3172 module#2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fpistm merged 1 commit intostm32duino:mainfromOliv4945:variant/RAK3172-Module

Apr 17, 2023

Merged

Add RAK3172 module#2005

fpistm merged 1 commit intostm32duino:mainfromOliv4945:variant/RAK3172-Module

Apr 17, 2023

Conversation

Copy link

Contributor

Oliv4945 commentedApr 13, 2023

Summary

This PR implements RAK3172 module bases on STM32WLE5CCU

As discussed the LoRaWAN repo (stm32duino/STM32LoRaWAN#13) it is cleaner to add it here.
This is still a draft as I did not update the main Readme because of a question: I created the sectionLoRa modules , but is it correct? If not, should I place it in theLoRa boards instead?

Validation

LoRaWAN works on the module. I did not test the other peripherals like SPI or I2C

Copy link

Member

fpistm commentedApr 13, 2023

Hi@Oliv4945
Thanks for this contribution.
Please add it to the LoRa section to avoid adding new one. I will review it tomorrow.

Copy link

ContributorAuthor

Oliv4945 commentedApr 14, 2023

Thanks@fpistm, I moved it.
I put a green heart as the "generic WLE5CC" but I saw that you put yellow on the Seeedstudio's E5 module, so please tell me your policy ;)

fpistm added the new variantAdd support of new bard label

Apr 14, 2023

fpistm added this to the2.6.0 milestone

Apr 14, 2023

Copy link

Member

fpistm commentedApr 14, 2023

Well while the new release including the board is not released I put it in yellow and moved to green when officially released.

fpistm self-requested a review

April 14, 2023 08:55

Copy link

ContributorAuthor

Oliv4945 commentedApr 14, 2023

Ok, updated

fpistm requested changes

Apr 14, 2023

View reviewed changes

variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_RAK3172_MODULE.h OutdatedShow resolvedHide resolved

variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_RAK3172_MODULE.cpp OutdatedShow resolvedHide resolved

Copy link

Member

fpistm commentedApr 14, 2023•
edited
Loading

Here the patch, if it helps.
Note that you can adapt analog pins if you want as I've defined all possible ones but rename the one as defined by RAK GH repo
patch1.patch

Copy link

ContributorAuthor

Oliv4945 commentedApr 14, 2023

Wow, thanks@fpistm and sorry for the mistakes. I have been mislead by another document with some other errors that I reported to RAK. I agree with all your changes except for PB5: unless I am using the wrong datasheet there is no ADC

Is that correct?

I order to avoid any further error also doubled checked the PIN definition with theirRUI BSP

Copy link

Member

fpistm commentedApr 14, 2023•
edited
Loading

Oups, you are right. PB5 has no ADC as defined in the generic:

Arduino_Core_STM32/variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_generic.h

Lines 28 to 38 in31e562d

	#definePA10 PIN_A0
	#definePA11 PIN_A1
	#definePA12 PIN_A2
	#definePA13 PIN_A3
	#definePA14 PIN_A4
	#definePA15 PIN_A5
	#definePB0 16
	#definePB2 PIN_A6
	#definePB3 PIN_A7
	#definePB4 PIN_A8
	#definePB5 20