Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix links for "WeAct MiniSTM32H7*" boards#1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 1 commit intostm32duino:mainfromper1234:remove-weact-links
Jan 28, 2023
Merged

Fix links for "WeAct MiniSTM32H7*" boards#1934

fpistm merged 1 commit intostm32duino:mainfromper1234:remove-weact-links
Jan 28, 2023

Conversation

per1234
Copy link
Contributor

Pull Request template

Summary

Fix useless, confusing, and potentially malicious links for "WeAct MiniSTM32H7*" boards.

CC:@ag88

This PR fixes/implements the followingbugs/features

  • Fix useless, confusing, and potentially malicious links for "WeAct MiniSTM32H7*" boards
  • Breaking changes

Explain themotivation for making this change. What existing problem does the pull request solve?

The previous links lead through a GitHub username change redirect to a repository that appears to be used to demonstrate a security vulnerability.

I replaced them with links to the repo under the WeActStudio GitHub account which actually contains information about the hardware. The other links for WeAct hardware in the readme are under that GitHub and the product listings under the "WeAct Studio Official Store" on AliExpress.

Validation

  1. Open the previous link:
    https://github.com/WeActTC/MiniSTM32H7xx
  2. Note that there is no useful information there.
  3. Note that the readme contains a link to a dependency, which is then explained to be a PoC placeholder for malware.
  4. Consider that a user visiting this link to get information about the board would only be confused and distressed by what they found there.
  5. Open the replacement link:
    https://github.com/WeActStudio/MiniSTM32H7xx
  6. Note that there is useful information.
  7. Open the "Official WeAct Studio Store" page on Aliexpress:
    https://weactstudio.aliexpress.com/store/1101545918
  8. Find the listing for the STM32H750VBT6 dev board.
  9. Note that the listing text containshttps://github.com/WeActStudio/MiniSTM32H7xx

Code formatting

  • Ensure AStyle check is passed thanks CI

N/A

Closing issues

None

The previous links lead through a GitHub username change redirect to a repository that appears to be used to demonstrate a security vulnerability.I replaced them with links to the repo under the WeActStudio GitHub account which actually contains information about the hardware. The other links for WeAct hardware in the readme are under that GitHub and the product listings under the "WeAct Studio Official Store" on AliExpress.
@fpistm
Copy link
Member

Thanks@per1234
I've corrected the same for F4 Mini but missed this one.

per1234 reacted with thumbs up emoji

@fpistmfpistm merged commit1357c08 intostm32duino:mainJan 28, 2023
@ag88
Copy link
Contributor

thanks,@per1234 , I did not realized the old repository has changed without notice and replaced with possibly malware.
notice that there is a redirect to a different repository which was originally addressed as WeActTC

per1234 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@per1234@fpistm@ag88

[8]ページ先頭

©2009-2025 Movatter.jp