Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: Incorporate ST feedback#1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 1 commit intostm32duino:mainfromzfields:swan_vcp
Oct 5, 2022
Merged

Conversation

zfields
Copy link
Contributor

@zfieldszfields commentedOct 4, 2022•
edited
Loading

Clarify Swan LP1 interface defines.

We liked/appreciated your feedback, but we didn't get it changed before you merged.
Thank you for your quick responses, and good advice. ;-)

fpistm reacted with laugh emoji
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@fpistmfpistm added the enhancementNew feature or request labelOct 4, 2022
@fpistmfpistm added this to the2.4.0 milestoneOct 4, 2022
@fpistm
Copy link
Member

We liked/appreciated your feedback, but we didn't get it changed before you merged.
Thank you for your quick responses, and good advice. ;-)

You didn't tell me you would make change 😛

@zfields
Copy link
ContributorAuthor

I thought I was fast, but you were faster... 😝

This one is ready when you are. 👍

@fpistmfpistm merged commited4ef2f intostm32duino:mainOct 5, 2022
@zfieldszfields deleted the swan_vcp branchFebruary 28, 2023 20:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

2 participants
@zfields@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp