Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add Nucleo F722ZE board#1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 2 commits intostm32duino:mainfromgautierg-st:add_nucleo_f722ze
Sep 16, 2022
Merged

Conversation

gautierg-st
Copy link
Contributor

Fixes#1259

Tested:

  • Serial
  • USB
  • I2C
  • SPI

@fpistmfpistm self-requested a reviewSeptember 16, 2022 09:32
@fpistmfpistm added the new variantAdd support of new bard labelSep 16, 2022
@fpistmfpistm added this to the2.4.0 milestoneSep 16, 2022
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice first PR. Somes minor remarks.
Anyway it misses the generic declaration.

Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It misses generic references in the README.md and the generic clock to add in thegeneric_clock.c (ex:https://github.com/stm32duino/Arduino_Core_STM32/pull/1712/files#diff-9c22d2f9bf0c6ada5a16b60c5dee88c8c2a5dbe87159623aea7fb4c3215dc56eL24)

Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Last round 😉
Else LGTM. Thanks.

Add the following generic variants:- STM32F722ZCTx- STM32F722ZETx- STM32F732ZETx
Fixesstm32duino#1259Tested:- Serial- USB- I2C- SPI
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@fpistmfpistm merged commit7a9b96d intostm32duino:mainSep 16, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

Assignees
No one assigned
Labels
new variantAdd support of new bard
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Nucleo 144 F722ZE
3 participants
@gautierg-st@nschurando@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp