Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Clean variants files#167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 1 commit intostm32duino:masterfromfpistm:variant_cleanup
Dec 6, 2017
Merged

Conversation

@fpistm
Copy link
Member

@fpistmfpistm commentedDec 5, 2017•
edited
Loading

  • Common definitions are moved to pins_arduino_var.h.
    They could be redefined in variant.h if needed.
  • RemovedUART_EMUL definitions as it is needed to be reworked in SoftwareSerial library.
  • Pin number over D15 replaced by pin name (more relevant)
  • Fixed some typos

- Common definitions are moved to pins_arduino_var.h.  They could be redefined in variant.h if needed.- Removed *UART_EMUL* definitions as it need to be reworked  in SoftwareSerial library.- Pin number over D15 replaced by pin name (more relevant)- Fixed some typosSigned-off-by: Frederic.Pillon <frederic.pillon@st.com>
@fpistmfpistm added the enhancementNew feature or request labelDec 5, 2017
@fpistmfpistm self-assigned thisDec 5, 2017
@fpistmfpistm requested a review froma userDecember 5, 2017 13:41
@Adminius
Copy link
Contributor

Adminius commentedDec 5, 2017•
edited
Loading

#ifndef is a good idea! ;)

@fpistm
Copy link
MemberAuthor

fpistm commentedDec 5, 2017•
edited
Loading

by default, for board with Arduino header, SCL and SDA are on D14/D15 , if the board you add do not have it, only define it properly in the variant.h:
Based on your example (I used PXn name to match silkscreen of your board):

//I2C Definitions#define SDA                    PA10#define SCL                     PA9

Note: why post in this PR instead of the#165?

Copy link

@ghostghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could we move also LED_BUILTIN and USER_BTN?

@fpistm
Copy link
MemberAuthor

Could we move also LED_BUILTIN and USER_BTN?

I'm wondered the same question, using those default values:

#define LED_BUILTIN             13#define USER_BTN                PC13

but some boards do not have LED or button, so I preferred to not define one by default.
Are you agreed with that?

@ghost
Copy link

Yes, I am.
In fact I missed the boards without LED or button.

@fpistm
Copy link
MemberAuthor

With this PR, variant is now cleaned and include only specific pin mapping

@fpistmfpistm merged commit0e046b5 intostm32duino:masterDec 6, 2017
@fpistmfpistm deleted the variant_cleanup branchDecember 6, 2017 14:13
benwaffle pushed a commit to benwaffle/Arduino_Core_STM32 that referenced this pull requestApr 10, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@fpistmfpistm

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fpistm@Adminius
[8]ページ先頭
©2009-2025 Movatter.jp