Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix variant WeActMiniH7xx, DevEBoxH7xx: ena peripheral pll clks#1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 4 commits intostm32duino:mainfromag88:variant_weactminih7xx
Dec 13, 2021

Conversation

ag88
Copy link
Contributor

@ag88ag88 commentedDec 11, 2021
edited
Loading

  • fix variant WeActMiniH7xx: ena peripheral pll clks

in previous commit#1552 some clocks from PLL2, PLL3
are not distributed to some peripherals

originally to save some power. However, users using those
pheriperials may mistake that it is not working

this fix distributes the missed out PLL clocks to all pheripherals
those clocks are at 80 Mhz

  • made the same fixes for DevEBoxH7xx

Pull Request template

Please, Make sure that your PR is not a duplicate.
Search among thePull request before creating one.

IMPORTANT: Please review theCONTRIBUTING.md file for detailed contributing guidelines.

Thanks for submitting a pull request.
Please provide enough information so that others can review your pull request:

Summary

This PR fixes/implements the followingbugs/features

  • Bug 1
    distribute missed out PLL clocks to all peripherals (previously commented out)
  • [ ]

bug fix

Validation

  • Ensure CI build is passed.
  • Demonstrate the code is solid. [e.g. Provide a sketch]

updated files in installed core and re-ran previous test in original commit.
#1552
compile, Arduino IDE 1.8.16:
Sketch uses 56148 bytes (2%) of program storage space. Maximum is 2097152 bytes.
Global variables use 4112 bytes (0%) of dynamic memory, leaving 520176 bytes for local variables. Maximum is 524288 bytes.

sample results:

p - print/stop printC - cpu full speedc - cpu half speedw - run whetstoneVref int (1.21v):374temp sensor:204mvolt:660temp:50.00Beginning Whetstone benchmark at 480 MHz ...Loops:10000, Iterations:1, Duration:1627.54 millisecC Converted Single Precision Whetstones:614.42 MflopsVref int (1.21v):375temp sensor:205mvolt:661temp:50.50Vref int (1.21v):376temp sensor:205mvolt:659temp:49.50Beginning Whetstone benchmark at 480 MHz ...Loops:10000, Iterations:1, Duration:1627.53 millisecC Converted Single Precision Whetstones:614.43 MflopsVref int (1.21v):374temp sensor:204mvolt:660

led blinking per normal

Code formatting

  • Ensure AStyle check is passed thanks CI

Closing issues

Fixes #xxx

ag88 added4 commitsDecember 12, 2021 02:12
in previous commmit some clocks from PLL2, PLL3are not distributed to some peripheralsstm32duino#1552originally to save some power. However, users using thosepheriperials may mistake that it is not workingthis fix distributes the missed out PLL clocks to all pheripheralsthose clocks are at 80 Mhz
in previous commit (stm32duino#1552)some clocks from PLL2, PLL3 are not distributed to some peripheralsoriginally to save some power. However, users using thosepheriperials may mistake that it is not workingthis fix distributes the missed out PLL clocks to all pheripheralsthose clocks are at 80 Mhz
make the same fixes fromstm32duino#1585---in previous commit (stm32duino#1552)some clocks from PLL2, PLL3 are not distributed to some peripheralsoriginally to save some power. However, users using thosepheriperials may mistake that it is not workingthis fix distributes the missed out PLL clocks to all pheripheralsthose clocks are at 80 Mhz---
@ag88ag88 changed the titlefix variant WeActMiniH7xx: ena peripheral pll clksfix variant WeActMiniH7xx, DevEBoxH7xx: ena peripheral pll clksDec 11, 2021
@fpistmfpistm added enhancementNew feature or request fix 🩹Bug fix labelsDec 13, 2021
@fpistmfpistm added this to the2.2.0 🎄 🎅 milestoneDec 13, 2021
@fpistmfpistm merged commitb8e39bc intostm32duino:mainDec 13, 2021
@fpistm
Copy link
Member

Thanks again@ag88 😉

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

Assignees
No one assigned
Labels
enhancementNew feature or requestfix 🩹Bug fix
Projects
None yet
Milestone
2.2.0 🎄 🎅
Development

Successfully merging this pull request may close these issues.

2 participants
@ag88@fpistm

[8]ページ先頭

©2009-2025 Movatter.jp