Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

WB enhancements#1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 5 commits intostm32duino:masterfromfpistm:WB_fix
Feb 4, 2021
Merged

WB enhancements#1291

fpistm merged 5 commits intostm32duino:masterfromfpistm:WB_fix
Feb 4, 2021

Conversation

fpistm
Copy link
Member

@fpistmfpistm commentedFeb 2, 2021•
edited
Loading

  • Remove OTP API from the variant and provide it as a bsp.
  • Enable HSEM HAL module by default
  • Move HSE Capacitor Tuning api to clock api file
  • Add required semaphore managements

Supersede#1290

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistmfpistm added enhancementNew feature or request fix 🩹Bug fix labelsFeb 2, 2021
@fpistmfpistm added this to the2.0.0 milestoneFeb 2, 2021
Copy link
Contributor

@ABOSTMABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, minor question ?

@fpistm
Copy link
MemberAuthor

@ABOSTM
note that the PR is no ended.

ABOSTM reacted with thumbs up emoji

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Copy link
Contributor

@ABOSTMABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think HSEM is necessary in analog.cpp when calling
__HAL_RCC_ADC_CONFIG()

fpistm reacted with thumbs up emoji
@fpistm
Copy link
MemberAuthor

I think HSEM is necessary in analog.cpp when calling
__HAL_RCC_ADC_CONFIG()

Right nice catch 👍

This new implementation is mroe generic and support MP1 as well WB.H7 could be added easily later if dual core support is implemented.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
WB serie will require more semaphore management forlow power and flash.Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistmfpistm requested a review fromABOSTMFebruary 4, 2021 13:45
@fpistmfpistm marked this pull request as ready for reviewFebruary 4, 2021 16:06
Copy link
Contributor

@ABOSTMABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

fpistm reacted with thumbs up emoji
@fpistmfpistm merged commit82cdead intostm32duino:masterFeb 4, 2021
@fpistmfpistm deleted the WB_fix branchFebruary 4, 2021 18:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ABOSTMABOSTMABOSTM approved these changes

@FRASTMFRASTMFRASTM approved these changes

Assignees
No one assigned
Labels
enhancementNew feature or requestfix 🩹Bug fix
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

3 participants
@fpistm@ABOSTM@FRASTM
[8]ページ先頭
©2009-2025 Movatter.jp