Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

enabling IPCC module of the stm32WB55#1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fpistm merged 1 commit intostm32duino:masterfromFRASTM:w55_BLE
Nov 30, 2020

Conversation

FRASTM
Copy link
Contributor

@FRASTMFRASTM commentedSep 25, 2020•
edited
Loading

This PR is the introduction of the BLE for the stm32WB55

Requiresstm32duino/STM32duinoBLE#17

@FRASTMFRASTM changed the title[WIP]enabling IPCC module of the stm32WB55[WIP] enabling IPCC module of the stm32WB55Sep 25, 2020
@fpistmfpistm marked this pull request as draftSeptember 25, 2020 12:43
@FRASTMFRASTMforce-pushed thew55_BLE branch 4 times, most recently from8231175 to5055463CompareNovember 2, 2020 18:01
@fpistmfpistm self-requested a reviewNovember 9, 2020 07:59
@fpistmfpistm added the enhancementNew feature or request labelNov 9, 2020
@fpistmfpistm assignedfpistm and unassignedfpistmNov 9, 2020
@fpistmfpistm added this to the2.0.0 milestoneNov 9, 2020
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In addition to my review comments, please:

  • Rebase and squash on top of the master and change commit message to something like:

[PNUCLEO_WB55RG] BLE support configuration

  • Enable IPCC HAL module
  • Manage OTP to ...
  • Update clock configuration
  • Apply astyle (script available in CI/astyle/astyle.py)

@FRASTM
Copy link
ContributorAuthor

fix according to the review (mainly astyle)
squash in one commit

@FRASTMFRASTMforce-pushed thew55_BLE branch 3 times, most recently from81a28f7 toe7133bbCompareNovember 9, 2020 10:34
@fpistmfpistm marked this pull request as ready for reviewNovember 9, 2020 13:13
@FRASTMFRASTMforce-pushed thew55_BLE branch 2 times, most recently froma17cf4e toc00f262CompareNovember 10, 2020 08:05
@FRASTMFRASTM changed the title[WIP] enabling IPCC module of the stm32WB55enabling IPCC module of the stm32WB55Nov 10, 2020
Enable IPCC HAL module which transport the HCI commandover the Shared Mem.Update clock configuration for BLE on this nucleo_wb55rgManage OTP to access the device bd addressSigned-off-by: Francois Ramu <francois.ramu@st.com>
Copy link
Member

@fpistmfpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM
Thanks@FRASTM

@fpistmfpistm merged commit6df682d intostm32duino:masterNov 30, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fpistmfpistmfpistm approved these changes

Assignees

@FRASTMFRASTM

Labels
enhancementNew feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

2 participants
@FRASTM@fpistm
[8]ページ先頭
©2009-2025 Movatter.jp