- Notifications
You must be signed in to change notification settings - Fork1k
Astyle indent preproc block#1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
To have it passed, could you rebase on top of the master, please? |
Looking at all changes, I will have to update my scripts to generate wrapper files and PinNamesVar.h to indent properly by default. |
7295118 toeb6817cCompareI pushed one more commit to let astyle enforce linux-style line endings. I noticed some CRLF-style files in the jumpsysBL branch, but when adding this option, notice@fpistm had already unified these in master. This just encodes this in the astyle config as well. |
Uh oh!
There was an error while loading.Please reload this page.
aef4a33 toeb6817cCompareThis indents preprocessor blocks, making nested preprocessor blockseasier to read.
This runs `python3 CI/astyle/astyle.py` and commits the result.
eb6817c to4ab0fc3CompareWhat shall we do with this PR? I've just rebased it on top of master again, maybe it could just be merged? There's still a few open PRs that would produce conflicts from this, but most of them are experimental and would need to be mostly redone anyway, I think? |
See:stm32duino/Arduino_Core_STM32#1007Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
See:stm32duino/Arduino_Core_STM32#1007Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Based on#1006, I quickly tried enabling the astyle ident-preproc-block to see what the impact would be. It produces a rather big diff, but on first glance does improve readability a lot.
Because it changes so much, this would probably mess with open pullrequests, so it might be good to merge those as far as possible (it is probably also possible to update them semi-automatically, but might still be a bit messy).