Commitd8a8b20

VitorBoss

and

fpistm

authored

Fix dead lock with pin above NUM_DIGITAL_PINS (#2629)

Penalty for the check should be a single instruction for pin numbers below NUM_DIGITAL_PINS, 9 for pin numbers between PNUM_ANALOG_BASE and NUM_ANALOG_INTERNAL_FIRST.Tests done on a Black F407VE boardSigned-off-by: Frederic Pillon <frederic.pillon@st.com>Co-authored-by: Frederic Pillon <frederic.pillon@st.com>

1 parentcfe4962 commitd8a8b20Copy full SHA for d8a8b20

File tree

1 file changed

+11

-3

lines changed

cores/arduino
- wiring_digital.c

1 file changed

+11

-3

lines changed

`‎cores/arduino/wiring_digital.c`

Lines changed: 11 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -78,17 +78,25 @@ void pinMode(uint32_t ulPin, uint32_t ulMode)`
`78`	`78`
`79`	`79`	`voiddigitalWrite(uint32_tulPin,uint32_tulVal)`
`80`	`80`	`{`
`81`		`-digitalWriteFast(digitalPinToPinName(ulPin),ulVal);`
	`81`	`+PinNamep=digitalPinToPinName(ulPin);`
	`82`	`+if (p!=NC) {`
	`83`	`+digitalWriteFast(p,ulVal);`
	`84`	`+ }`
`82`	`85`	`}`
`83`	`86`
`84`	`87`	`intdigitalRead(uint32_tulPin)`
`85`	`88`	`{`
`86`		`-returndigitalReadFast(digitalPinToPinName(ulPin));`
	`89`	`+PinNamep=digitalPinToPinName(ulPin);`
	`90`	`+`
	`91`	`+return (p==NC) ?0 :digitalReadFast(p);`
`87`	`92`	`}`
`88`	`93`
`89`	`94`	`voiddigitalToggle(uint32_tulPin)`
`90`	`95`	`{`
`91`		`-digitalToggleFast(digitalPinToPinName(ulPin));`
	`96`	`+PinNamep=digitalPinToPinName(ulPin);`
	`97`	`+if (p!=NC) {`
	`98`	`+digitalToggleFast(digitalPinToPinName(ulPin));`
	`99`	`+ }`
`92`	`100`	`}`
`93`	`101`
`94`	`102`	`#ifdef__cplusplus`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd8a8b20

File tree

1 file changed

1 file changed

`‎cores/arduino/wiring_digital.c`

0 commit comments