Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: addblas/ext/index-of#7565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
headlessNode wants to merge28 commits intostdlib-js:develop
base:develop
Choose a base branch
Loading
fromheadlessNode:top-blas-indexof

Conversation

headlessNode
Copy link
Member

Progresses#2656.

Description

What is the purpose of this pull request?

This pull request:

  • addblas/ext/index-of

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-botstdlib-bot added the BLASIssue or pull request related to Basic Linear Algebra Subprograms (BLAS). labelJul 5, 2025
@headlessNodeheadlessNode added FeatureIssue or pull request for adding a new feature. GSoCGoogle Summer of Code. gsoc: 2025Google Summer of Code (2025). and removed BLASIssue or pull request related to Basic Linear Algebra Subprograms (BLAS). labelsJul 5, 2025
@stdlib-botstdlib-bot added the BLASIssue or pull request related to Basic Linear Algebra Subprograms (BLAS). labelJul 5, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commentedJul 5, 2025•
edited
Loading

Coverage Report

PackageStatementsBranchesFunctionsLines
blas/ext/index-of$\color{red}656/666$
$\color{green}+98.50\%$		$\color{red}74/78$
$\color{green}+94.87\%$		$\color{green}3/3$
$\color{green}+100.00\%$		$\color{red}656/666$
$\color{green}+98.50\%$

The above coverage report was generated for thechanges in this PR.

---type: pre_commit_static_analysis_reportdescription: Results of running static analysis checks when committing changes.report:  - task: lint_filenames    status: passed  - task: lint_editorconfig    status: passed  - task: lint_markdown    status: na  - task: lint_package_json    status: na  - task: lint_repl_help    status: na  - task: lint_javascript_src    status: passed  - task: lint_javascript_cli    status: na  - task: lint_javascript_examples    status: na  - task: lint_javascript_tests    status: na  - task: lint_javascript_benchmarks    status: na  - task: lint_python    status: na  - task: lint_r    status: na  - task: lint_c_src    status: na  - task: lint_c_examples    status: na  - task: lint_c_benchmarks    status: na  - task: lint_c_tests_fixtures    status: na  - task: lint_shell    status: na  - task: lint_typescript_declarations    status: na  - task: lint_typescript_tests    status: na  - task: lint_license_headers    status: passed---
Co-authored-by: Athan <kgryte@gmail.com>Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
headlessNodeand others added2 commitsJuly 9, 2025 09:49
Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
Co-authored-by: Athan <kgryte@gmail.com>Signed-off-by: Muhammad Haris <101793258+headlessNode@users.noreply.github.com>
@kgrytekgryte self-requested a reviewJuly 9, 2025 05:49
@kgrytekgryte added Needs ReviewA pull request which needs code review. and removed Needs ReviewA pull request which needs code review. labelsJul 9, 2025
---type: pre_commit_static_analysis_reportdescription: Results of running static analysis checks when committing changes.report:  - task: lint_filenames    status: passed  - task: lint_editorconfig    status: passed  - task: lint_markdown    status: na  - task: lint_package_json    status: na  - task: lint_repl_help    status: na  - task: lint_javascript_src    status: na  - task: lint_javascript_cli    status: na  - task: lint_javascript_examples    status: na  - task: lint_javascript_tests    status: na  - task: lint_javascript_benchmarks    status: na  - task: lint_python    status: na  - task: lint_r    status: na  - task: lint_c_src    status: na  - task: lint_c_examples    status: na  - task: lint_c_benchmarks    status: na  - task: lint_c_tests_fixtures    status: na  - task: lint_shell    status: na  - task: lint_typescript_declarations    status: passed  - task: lint_typescript_tests    status: na  - task: lint_license_headers    status: passed---
…sion---type: pre_commit_static_analysis_reportdescription: Results of running static analysis checks when committing changes.report:  - task: lint_filenames    status: passed  - task: lint_editorconfig    status: passed  - task: lint_markdown    status: na  - task: lint_package_json    status: passed  - task: lint_repl_help    status: na  - task: lint_javascript_src    status: passed  - task: lint_javascript_cli    status: na  - task: lint_javascript_examples    status: passed  - task: lint_javascript_tests    status: na  - task: lint_javascript_benchmarks    status: na  - task: lint_python    status: na  - task: lint_r    status: na  - task: lint_c_src    status: na  - task: lint_c_examples    status: na  - task: lint_c_benchmarks    status: na  - task: lint_c_tests_fixtures    status: na  - task: lint_shell    status: na  - task: lint_typescript_declarations    status: na  - task: lint_typescript_tests    status: na  - task: lint_license_headers    status: passed---
---type: pre_commit_static_analysis_reportdescription: Results of running static analysis checks when committing changes.report:  - task: lint_filenames    status: passed  - task: lint_editorconfig    status: passed  - task: lint_markdown    status: na  - task: lint_package_json    status: na  - task: lint_repl_help    status: na  - task: lint_javascript_src    status: passed  - task: lint_javascript_cli    status: na  - task: lint_javascript_examples    status: na  - task: lint_javascript_tests    status: na  - task: lint_javascript_benchmarks    status: na  - task: lint_python    status: na  - task: lint_r    status: na  - task: lint_c_src    status: na  - task: lint_c_examples    status: na  - task: lint_c_benchmarks    status: na  - task: lint_c_tests_fixtures    status: na  - task: lint_shell    status: na  - task: lint_typescript_declarations    status: na  - task: lint_typescript_tests    status: na  - task: lint_license_headers    status: passed---
…sion---type: pre_commit_static_analysis_reportdescription: Results of running static analysis checks when committing changes.report:  - task: lint_filenames    status: passed  - task: lint_editorconfig    status: passed  - task: lint_markdown    status: na  - task: lint_package_json    status: na  - task: lint_repl_help    status: na  - task: lint_javascript_src    status: passed  - task: lint_javascript_cli    status: na  - task: lint_javascript_examples    status: na  - task: lint_javascript_tests    status: na  - task: lint_javascript_benchmarks    status: na  - task: lint_python    status: na  - task: lint_r    status: na  - task: lint_c_src    status: na  - task: lint_c_examples    status: na  - task: lint_c_benchmarks    status: na  - task: lint_c_tests_fixtures    status: na  - task: lint_shell    status: na  - task: lint_typescript_declarations    status: na  - task: lint_typescript_tests    status: na  - task: lint_license_headers    status: passed---
---type: pre_commit_static_analysis_reportdescription: Results of running static analysis checks when committing changes.report:  - task: lint_filenames    status: passed  - task: lint_editorconfig    status: passed  - task: lint_markdown    status: na  - task: lint_package_json    status: na  - task: lint_repl_help    status: passed  - task: lint_javascript_src    status: na  - task: lint_javascript_cli    status: na  - task: lint_javascript_examples    status: na  - task: lint_javascript_tests    status: na  - task: lint_javascript_benchmarks    status: na  - task: lint_python    status: na  - task: lint_r    status: na  - task: lint_c_src    status: na  - task: lint_c_examples    status: na  - task: lint_c_benchmarks    status: na  - task: lint_c_tests_fixtures    status: na  - task: lint_shell    status: na  - task: lint_typescript_declarations    status: na  - task: lint_typescript_tests    status: na  - task: lint_license_headers    status: passed---
---type: pre_commit_static_analysis_reportdescription: Results of running static analysis checks when committing changes.report:  - task: lint_filenames    status: passed  - task: lint_editorconfig    status: passed  - task: lint_markdown    status: na  - task: lint_package_json    status: na  - task: lint_repl_help    status: na  - task: lint_javascript_src    status: na  - task: lint_javascript_cli    status: na  - task: lint_javascript_examples    status: na  - task: lint_javascript_tests    status: na  - task: lint_javascript_benchmarks    status: na  - task: lint_python    status: na  - task: lint_r    status: na  - task: lint_c_src    status: na  - task: lint_c_examples    status: na  - task: lint_c_benchmarks    status: na  - task: lint_c_tests_fixtures    status: na  - task: lint_shell    status: na  - task: lint_typescript_declarations    status: passed  - task: lint_typescript_tests    status: passed  - task: lint_license_headers    status: passed---
---type: pre_commit_static_analysis_reportdescription: Results of running static analysis checks when committing changes.report:  - task: lint_filenames    status: passed  - task: lint_editorconfig    status: passed  - task: lint_markdown    status: passed  - task: lint_package_json    status: na  - task: lint_repl_help    status: passed  - task: lint_javascript_src    status: passed  - task: lint_javascript_cli    status: na  - task: lint_javascript_examples    status: na  - task: lint_javascript_tests    status: na  - task: lint_javascript_benchmarks    status: na  - task: lint_python    status: na  - task: lint_r    status: na  - task: lint_c_src    status: na  - task: lint_c_examples    status: na  - task: lint_c_benchmarks    status: na  - task: lint_c_tests_fixtures    status: na  - task: lint_shell    status: na  - task: lint_typescript_declarations    status: na  - task: lint_typescript_tests    status: na  - task: lint_license_headers    status: passed---
Copy link
Member

@kgrytekgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've updated the implementation. The only thing remaining are updating the tests. I suggest you take this on, as this will be a good exercise in both verifying my changes and understanding the changes made.

headlessNode reacted with thumbs up emoji
@kgrytekgryte added Needs ChangesPull request which needs changes before being merged. and removed Needs ReviewA pull request which needs code review. labelsJul 11, 2025
kgryteand others added3 commitsJuly 10, 2025 23:52
---type: pre_commit_static_analysis_reportdescription: Results of running static analysis checks when committing changes.report:  - task: lint_filenames    status: passed  - task: lint_editorconfig    status: passed  - task: lint_markdown    status: passed  - task: lint_package_json    status: na  - task: lint_repl_help    status: na  - task: lint_javascript_src    status: na  - task: lint_javascript_cli    status: na  - task: lint_javascript_examples    status: na  - task: lint_javascript_tests    status: na  - task: lint_javascript_benchmarks    status: na  - task: lint_python    status: na  - task: lint_r    status: na  - task: lint_c_src    status: na  - task: lint_c_examples    status: na  - task: lint_c_benchmarks    status: na  - task: lint_c_tests_fixtures    status: na  - task: lint_shell    status: na  - task: lint_typescript_declarations    status: na  - task: lint_typescript_tests    status: na  - task: lint_license_headers    status: passed---
---type: pre_commit_static_analysis_reportdescription: Results of running static analysis checks when committing changes.report:  - task: lint_filenames    status: passed  - task: lint_editorconfig    status: passed  - task: lint_markdown    status: na  - task: lint_package_json    status: na  - task: lint_repl_help    status: na  - task: lint_javascript_src    status: na  - task: lint_javascript_cli    status: na  - task: lint_javascript_examples    status: na  - task: lint_javascript_tests    status: passed  - task: lint_javascript_benchmarks    status: na  - task: lint_python    status: na  - task: lint_r    status: na  - task: lint_c_src    status: na  - task: lint_c_examples    status: na  - task: lint_c_benchmarks    status: na  - task: lint_c_tests_fixtures    status: na  - task: lint_shell    status: na  - task: lint_typescript_declarations    status: na  - task: lint_typescript_tests    status: na  - task: lint_license_headers    status: passed---
---type: pre_commit_static_analysis_reportdescription: Results of running static analysis checks when committing changes.report:  - task: lint_filenames    status: passed  - task: lint_editorconfig    status: passed  - task: lint_markdown    status: na  - task: lint_package_json    status: na  - task: lint_repl_help    status: na  - task: lint_javascript_src    status: na  - task: lint_javascript_cli    status: na  - task: lint_javascript_examples    status: na  - task: lint_javascript_tests    status: passed  - task: lint_javascript_benchmarks    status: na  - task: lint_python    status: na  - task: lint_r    status: na  - task: lint_c_src    status: na  - task: lint_c_examples    status: na  - task: lint_c_benchmarks    status: na  - task: lint_c_tests_fixtures    status: na  - task: lint_shell    status: na  - task: lint_typescript_declarations    status: na  - task: lint_typescript_tests    status: na  - task: lint_license_headers    status: passed---
@stdlib-botstdlib-bot added the Needs ReviewA pull request which needs code review. labelJul 12, 2025
@kgrytekgryte removed the Needs ChangesPull request which needs changes before being merged. labelJul 12, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@kgrytekgryteAwaiting requested review from kgryte

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
BLASIssue or pull request related to Basic Linear Algebra Subprograms (BLAS).FeatureIssue or pull request for adding a new feature.GSoCGoogle Summer of Code.gsoc: 2025Google Summer of Code (2025).Needs ReviewA pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@headlessNode@stdlib-bot@kgryte
[8]ページ先頭
©2009-2025 Movatter.jp