Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork98
Update dependencies 24-03-2025#532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
semanticdiff-combot commentedMar 19, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Review changes with Changed Files
|
0e90b68 toe80e658Comparee80e658 to89d8757CompareThis change removes the "experimental" Cargo feature from theresulting static-web-server **binary** temporarily (not the Cargofeature itself) to prevent shipping this vulnerable code along withSWS binary.The "experimental" Cargo feature will be restored once the upstreampatch is available.Old Windows 7, 8, 8.1 patch:Addtionally, it pins zerofrom, zerofrom-derive, litemapdependencies **temporarily** to be able to build SWS for old Windows7, 8, 8.1 because newer versions of them require rustc 1.81 or later.
89d8757 to373dd31Comparead4c171 intomaster 35 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
dependencyRelated to dependencies enhancementNew feature or request securityRelated to Security v2v2 release
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
This PR updates dependencies as usual to provide security, bug fixes and improvements.
Security patch for RUSTSEC-2024-0437
This change removes the
experimentalCargo feature from the resultingstatic-web-serverbinary temporarily (not the Cargo feature itself) to prevent shipping the security vulnerability#530 in an eventual release.The
experimentalCargo feature will be restored to be part of the binary again once the upstream patch isavailable.
References
Old Windows 7, 8, 8.1 patch
We use the following patch in the
Cargo.tomlto be able to build SWS for old Windows 7, 8, 8.1 temporarily (#447) by pinning dependencies (MSRV 1.76.0) because newer versions of them require rustc 1.81 or later.Remember,Microsoft stopped support for Windows 7 in 2020 (2023 for extended users). Sotake into account that we will not keep supporting this unmaintained platform for so long. Therefore, we could reconsider bumping up the MSRV in future SWS releases when convenient. We will advise users accordingly when this will occur and provide a patch if they need to build SWS manually for those old platforms.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):