Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

The closing body tag has been moved right before the closing html tag#511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
joseluisq merged 2 commits intostatic-web-server:masterfromalxv-su:master
Dec 10, 2024

Conversation

alxv-su
Copy link
Contributor

It was a mistake in the html hierarhy: the body contained only h1 tag.

Description

I moved closing body tag right before closing html tag.

Related Issue

It is too obvious to create an issue.

Motivation and Context

Compliance with HTML specification.

How Has This Been Tested?

I checked source code of directory listing returned by fixed static-web-server usinghttps://validator.w3.org/nu/#textarea

@semanticdiff-comSemanticDiff.com
Copy link

semanticdiff-combot commentedDec 10, 2024•
edited
Loading

Review changes with  SemanticDiff

Changed Files
FileStatus
  src/directory_listing.rs  97% smaller

@joseluisqjoseluisq added v2v2 release bugfixThis is PR fixes a bug labelsDec 10, 2024
Copy link
Collaborator

@joseluisqjoseluisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch! Please just resolve the minor formatting suggestions.

Copy link
Collaborator

@joseluisqjoseluisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@joseluisqjoseluisq merged commit206900b intostatic-web-server:masterDec 10, 2024
26 checks passed
@joseluisqjoseluisq modified the milestones:v2.34.1,v2.35.0Jan 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@joseluisqjoseluisqjoseluisq approved these changes

Assignees
No one assigned
Labels
bugfixThis is PR fixes a bugv2v2 release
Projects
None yet
Milestone
v2.35.0
Development

Successfully merging this pull request may close these issues.

2 participants
@alxv-su@joseluisq
[8]ページ先頭
©2009-2025 Movatter.jp