Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork98
Don't set Last-Modified if mtime is Unix epoch#488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Don't set Last-Modified if mtime is Unix epoch#488
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Resolves#487Signed-off-by: Akhil Velagapudi <4@4khil.com>
semanticdiff-combot commentedOct 14, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Review changes withSemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is63% smaller than the GitHub diff.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
de8482d intostatic-web-server:masterUh oh!
There was an error while loading.Please reload this page.
Resolves#487
If the file's modified time is the UNIX epoch, then it's likely not valid and should not be included in the Last-Modified header to avoid cache revalidation issues. Tested on a NixOS container.