Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix wrongContent-Encoding when enabling both compression and compression-static features#471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

joseluisq
Copy link
Collaborator

@joseluisqjoseluisq commentedAug 12, 2024•
edited
Loading

Description

This PR fixes a wrongContent-Encoding header value in the response whencompression andcompression-static features are enabled (either via CLI or a config file) due to SWS compression (dynamic) module performing the post-processing even if a pre-compressed file was found.

Related Issue

Itfixes#470

Motivation and Context

How Has This Been Tested?

static-web-server -p 8787 -d docker/public/ --compression --compression-static

Before

curl -sD - -o /dev/null -H"Accept-Encoding: gzip, zstd, br" http://localhost:8787/assets/main.css# HTTP/1.1 200 OK# last-modified: Mon, 12 Aug 2024 22:56:47 GMT# content-type: text/css# accept-ranges: bytes# vary: accept-encoding# content-encoding: gzip, gzip# cache-control: public, max-age=31536000# transfer-encoding: chunked# date: Mon, 12 Aug 2024 23:16:59 GMT

After

curl -sD - -o /dev/null -H"Accept-Encoding: gzip, zstd, br" http://localhost:8787/assets/main.css# HTTP/1.1 200 OK# last-modified: Mon, 12 Aug 2024 22:56:47 GMT# content-type: text/css# accept-ranges: bytes# content-encoding: gzip# vary: accept-encoding# cache-control: public, max-age=31536000# transfer-encoding: chunked# date: Mon, 12 Aug 2024 23:18:14 GMT

Screenshots (if appropriate):

@joseluisqjoseluisq added v2v2 release bugfixThis is PR fixes a bug labelsAug 12, 2024
@semanticdiff-comSemanticDiff.com
Copy link

semanticdiff-combot commentedAug 12, 2024•
edited
Loading

Review changes withSemanticDiff.

Analyzed 2 of 3 files.

FilenameStatus
✔️tests/compression.rsAnalyzed
❔tests/fixtures/toml/handler_fixtures.tomlUnsupported file format
✔️src/compression.rsAnalyzed

@joseluisqjoseluisq merged commita72c7b3 intomasterAug 12, 2024
38 checks passed
@joseluisqjoseluisq deleted the fix-wrong-content-encoding-compressions-enabled branchAugust 12, 2024 23:32
@joseluisqjoseluisq added this to thev2.33.0 milestoneAug 12, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfixThis is PR fixes a bugv2v2 release
Projects
None yet
Milestone
v2.32.2
Development

Successfully merging this pull request may close these issues.

Incorrectcontent-encoding forgzip when file is already available +compression-static
1 participant
@joseluisq
[8]ページ先頭
©2009-2025 Movatter.jp