Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork98
Fix test execution issues when running cargo tests passing non-SWS arguments#466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
When running tests with additional non-sws arguments, tests executionfails because sws is trying to parse cli arguments anyways.Now, sws won't parse arguments by default when running tests.For example, the following command will work as expected:cargo test -- --test-threads 1 --nocapture
semanticdiff-combot commentedJul 22, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Review changes withSemanticDiff. Analyzed 6 of 6 files. Overall, the semantic diff is17% smaller than the GitHub diff.
|
2 tasks
915d040 intomaster 39 checks passed
Uh oh!
There was an error while loading.Please reload this page.
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
This PR fixes an issue when running tests via Cargo with additional non-SWS arguments.
This was because SWS tried to parse CLI arguments in a test context.
Now, SWS won't parse arguments by default when running tests. So the following command will work as expected (run all tests):
cargotest -- --test-threads 1 --nocaptureRelated Issue
Itfixes#465
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):