Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove redundantasync function signatures#457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
joseluisq merged 1 commit intomasterfromclean-up-redundant-async-functions
Jun 26, 2024

Conversation

joseluisq
Copy link
Collaborator

@joseluisqjoseluisq commentedJun 26, 2024
edited
Loading

Description

This PR improves the code signature of someasync functions and makes themsync to communicate better the function's intention.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

@joseluisqjoseluisq added enhancementNew feature or request v2v2 release codebaseRelated to the project's source code labelsJun 26, 2024
@semanticdiff-comSemanticDiff.com
Copy link

semanticdiff-combot commentedJun 26, 2024
edited
Loading

Review changes withSemanticDiff.

Analyzed 9 of 9 files.

Overall, the semantic diff is51% smaller than the GitHub diff.

FilenameStatus
✔️src/compression_static.rs15.28% smaller
✔️src/control_headers.rs5.09% smaller
✔️src/directory_listing.rs47.31% smaller
✔️src/https_redirect.rs16.67% smaller
✔️src/response.rs16.67% smaller
✔️src/server.rs75.0% smaller
✔️src/static_files.rs63.81% smaller
✔️tests/cors.rs5.41% smaller
✔️tests/settings.rs5.2% smaller

@joseluisqjoseluisq changed the titleRemove redundantasync functionsRemove redundantasync function signaturesJun 26, 2024
@joseluisqjoseluisq merged commit4c805d6 intomasterJun 26, 2024
39 checks passed
@joseluisqjoseluisq deleted the clean-up-redundant-async-functions branchJune 26, 2024 23:35
@joseluisqjoseluisq added this to thev2.332.0 milestoneJun 26, 2024
@joseluisqjoseluisq modified the milestone:v2.32.1Jul 20, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codebaseRelated to the project's source codeenhancementNew feature or requestv2v2 release
Projects
None yet
Milestone
v2.32.1
Development

Successfully merging this pull request may close these issues.

1 participant
@joseluisq

[8]ページ先頭

©2009-2025 Movatter.jp