Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork597
[5.x] Fix nocache tag not replacing element correctly#13177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
duncanmcclean wants to merge1 commit into5.xChoose a base branch
base:5.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+14 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This was referencedNov 26, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue caused by#12929, where the nocache tag wasn't replacing the
<span>element as expected.In my testing, this PR seems to fix both issues, in addition to supporting shadow root elements (which the previous PR added support for).
This is the template I was testing with:
{{nocache }} <pclass="mb-6">only element</p>{{/nocache }}<ulclass="flex items-center mb-6"> {{nocache }} {{nav:header }} <li> <aclass="py-1.5 px-3 rounded-md {{ifis_current }} bg-white font-medium {{else }} text-blue-600 hover:bg-white {{/if }}"href="{{url }}">{{title }}</a> </li> {{/nav:header }} {{/nocache }}</ul>{{nocache }} <div> <templateshadowrootmode="open">...</template> </div>{{/nocache }}Fixes#13114
Fixes#13141