Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork577
[5.x] Fix incorrect blueprint being resolved on localizations#11810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:5.x
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
PhilJ commentedJul 4, 2025
+1 Merging this pull request would fix the issue we have with our multi page setup. We get 404 errors on localized pages due to the wrong blueprint being loaded. |
Duncan, this is still a draft. Is it waiting on something? |
duncanmcclean commentedJul 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It works but we weren't sure if it was the "right" approach or not. Anyways, I've marked this as ready for review. Feel free to change it if you want. |
Uh oh!
There was an error while loading.Please reload this page.
This pull request attempts to fix an issue where the incorrect blueprint is resolved on localisations, where the collection is dated and
hide: true
is set on the entry blueprint.I'm not sure that this is the final fix, but it certainly fixes it on the sites I've tested it on.
Related to support ticket
#7046
.Steps to reproduce
home
(should be hidden)landing_pages
blueprint: home
home
to be returned, because we're explicitly setting the blueprint on the origin entry.landing_pages
will be returned instead.landing_pages
since thehome
blueprint is hidden.BasicStore@getItem
callsEntry@ getCurrentDirtyStateAttributes()
, it attempts to get the entry date, which ends up calling theblueprint()
method.Entry@hasDate
.TLDR:
php artisan cache:clear
before attempting to get the localization's blueprint.