Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add bower dependencies#136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
oliversalzburg merged 1 commit intostacktracejs:masterfromoliversalzburg:fix/bower
Oct 19, 2015
Merged

Add bower dependencies#136

oliversalzburg merged 1 commit intostacktracejs:masterfromoliversalzburg:fix/bower
Oct 19, 2015

Conversation

@oliversalzburg
Copy link
Member

Fixes#134

@eriwen
Copy link
Member

👍

@oliversalzburg
Copy link
MemberAuthor

@eriwen We should probably tag stacktrace-gps and stacktrace.js with a patch update and update the bower.json to that version. Then the dependencies should be pulled in.

Another option I was considering was to specify the.min.js version as themain file. That one contains all the dependencies as well.

@eriwen
Copy link
Member

@oliversalzburg Yes, we should tag and publish a new release for those projects. You no longer have to wait for me to publish to npm! Make sure to bump and push gps, then bump the versions in stacktrace.js, tag and push that.

Regarding the bower dependencies, we used.min.js for component.json, so it makes sense to do the same here. Thanks!

@oliversalzburg
Copy link
MemberAuthor

@eriwen Okay, so, if we set the.min.js versions in themain section, then we don't really need to specify other packages as dependencies. We should set the referenced packages asdevDependencies then instead.

Unless you disagree, I would make that change, merge, tag, push and npm publish :)

bower.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's bump this to 2.3.0

@eriwen
Copy link
Member

Once we can rebase this PR on the HEAD of master and update the stacktrace-gps dependency, you can merge this and push a new version@oliversalzburg. Thanks!

oliversalzburg added a commit that referenced this pull requestOct 19, 2015
@oliversalzburgoliversalzburg merged commit2934891 intostacktracejs:masterOct 19, 2015
@oliversalzburgoliversalzburg deleted the fix/bower branchOctober 19, 2015 18:46
@oliversalzburg
Copy link
MemberAuthor

I didn't change themain to the minified build as thecomponent.json actually doesn't reference it either. Not sure how to proceed here. I still think it would make sense to make that change, but I wanted to delay it until a working bower setup is in place.

I pushed a 1.0.1 tag and published to npm. I didn't touch the dependencies as abower i stacktrace-js seems to already perform as intended. Not sure if anything else is actually needed.

I'll probably reference the bower dependency in our own projects very soon and then I'll get some real-world experience and adjust accordingly, if necessary.

$ bower i stacktrace-jsbower stacktrace-js#*           cached git://github.com/stacktracejs/stacktrace.js.git#1.0.0bower stacktrace-js#*         validate 1.0.0 against git://github.com/stacktracejs/stacktrace.js.git#*bower stacktrace-js#*              new version for git://github.com/stacktracejs/stacktrace.js.git#*bower stacktrace-js#*          resolve git://github.com/stacktracejs/stacktrace.js.git#*bower stacktrace-js#*         download https://github.com/stacktracejs/stacktrace.js/archive/1.0.1.tar.gzbower stacktrace-js#*          extract archive.tar.gzbower stacktrace-js#*         resolved git://github.com/stacktracejs/stacktrace.js.git#1.0.1bower stacktrace-gps#~2.3.0 not-cached git://github.com/stacktracejs/stacktrace-gps.git#~2.3.0bower stacktrace-gps#~2.3.0    resolve git://github.com/stacktracejs/stacktrace-gps.git#~2.3.0bower stack-generator#~1.0.7    cached git://github.com/stacktracejs/stack-generator.git#1.0.7bower stack-generator#~1.0.7  validate 1.0.7 against git://github.com/stacktracejs/stack-generator.git#~1.0.7bower error-stack-parser#~1.2.3 cached git://github.com/stacktracejs/error-stack-parser.git#1.2.3bower error-stack-parser#~1.2.3         validate 1.2.3 against git://github.com/stacktracejs/error-stack-parser.git#~1.2.3bower stacktrace-gps#~2.3.0             download https://github.com/stacktracejs/stacktrace-gps/archive/2.3.0.tar.gzbower stackframe#~0                       cached git://github.com/stacktracejs/stackframe.git#0.3.1bower stackframe#~0                     validate 0.3.1 against git://github.com/stacktracejs/stackframe.git#~0bower stacktrace-gps#~2.3.0              extract archive.tar.gzbower stacktrace-gps#~2.3.0             resolved git://github.com/stacktracejs/stacktrace-gps.git#2.3.0bower source-map#0.5.1                    cached git://github.com/mozilla/source-map.git#0.5.1bower source-map#0.5.1                  validate 0.5.1 against git://github.com/mozilla/source-map.git#0.5.1bower stacktrace-js#~1.0.1               install stacktrace-js#1.0.1bower error-stack-parser#~1.2.3          install error-stack-parser#1.2.3bower stack-generator#~1.0.7             install stack-generator#1.0.7bower stackframe#~0                      install stackframe#0.3.1bower stacktrace-gps#~2.3.0              install stacktrace-gps#2.3.0bower source-map#0.5.1                   install source-map#0.5.1

@eriwen
Copy link
Member

@oliversalzburg Yeah, this works just fine. The only possible hangup I can see is the complexity of including all dependencies if a consumer does not use the minified version atbower_components/stacktrace-js/dist/stacktrace.min.js

eriwen pushed a commit that referenced this pull requestApr 16, 2016
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oliversalzburg@eriwen
[8]ページ先頭
©2009-2025 Movatter.jp