- Notifications
You must be signed in to change notification settings - Fork280
Convert reports to JSON#135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
dist/stacktrace.min.js Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Line is too long.
Missing semicolon.
Expected an identifier and instead saw '=='.
Expected an operator and instead saw 'typeof'.
Expected an assignment or function call and instead saw an expression.
Wrap an immediate function invocation in parens to assist the reader in understanding that the expression is the result of a function, and not the function itself.
'e' is already defined.
't' is already defined.
Possible strict violation.
Expected '{' and instead saw 'throw'.
Expected '{' and instead saw 'return'.
'i' is already defined.
Use '!==' to compare with 'null'.
Too many errors. (50% scanned).
oliversalzburg commentedOct 15, 2015
@eriwen Can we exclude |
eriwen commentedOct 16, 2015
@oliversalzburg Looks like we can exclude files from Hound by adding a .jshintignore file with the following content: I'm not sure about Travis. It works on master and we haven't made changes. Maybe something is wrong with the PR-specific config somehow... |
eriwen commentedOct 16, 2015
Also, this looks good except for the one thing; thank you! |
gulpfile.js Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should go inpolyfills
oliversalzburg commentedOct 16, 2015
|
Includes JSON3 in the polyfill versionFixes#133
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Line is too long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
How can that still be too long? O_o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hm.. I'm guessing the default line length limit is 80.
Sorry about the annoying Hound stuff; don't worry about this kinda thing. I may just disable it since JSHint is part of the build anyway.
eriwen commentedOct 17, 2015
Looks good! |
Includes JSON3 in the polyfill version
Fixes#133