- Notifications
You must be signed in to change notification settings - Fork53
Add a failling test for node paths with parens#61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
mattwynne wants to merge1 commit intostacktracejs:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
3bbcef2 to8f96eabCompareContributorAuthor
mattwynne commentedJul 19, 2021
I don't know who needs to hear this but I have no |
Contributor
niftylettuce commentedFeb 11, 2022
If this is still an issue, can you resolve the conflict and ping me back once done? |
ContributorAuthor
mattwynne commentedMay 5, 2022
We ended up solving the problem byswitching to stackchain so I've lost personal interest in this I'm afraid. |
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
See#62
This PR is just a failing test to reproduce the problem. I'm hoping it should help someone who's anewcomer to open source and wants to contribute a fix.
I expect we can close this PR without merging it when someone submits a better PR that includes a fix 😄
Motivation and Context
Failing test to reproduce#62
How Has This Been Tested?
Added a new test case in spec/error-stack-parser-spec.js for this scenario.
Types of changes
Checklist:
node_modules/.bin/jscs -c .jscsrc error-stack-parser.jspasses without errorsnpm testpasses without errors