Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added support for searching large amount of indices#412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jonhealy1 merged 7 commits intostac-utils:mainfromsimonvb00:main
Jul 18, 2025

Conversation

simonvb00
Copy link
Contributor

@simonvb00simonvb00 commentedJul 16, 2025
edited
Loading

Description:
When searching the catalog with the/search-endpoint, aGET /<indices>/_search request is done with all indices listed in the URL path. However when doing such a search on a large amount of indices, it is possible that the size of the endpoint exceeds Elasticsearch’s maximum allowed HTTP line length (4096 bytes), resulting in the following error:

{"code":"RequestError","description":"RequestError(400, 'too_long_http_line_exception', 'An HTTP line is larger than 4096 bytes.')"}

The solution in this commit moves the indices from the endpoint to the body of the request once the amount of indices passes a certain threshold. The indices of the endpoint will be replaced byITEM_INDICES. Since the query still filters on the correct indices, this change preserves the behavior while avoiding the URL length limitation.

PR Checklist:

  • Code is formatted and linted (runpre-commit run --all-files)
  • Tests pass (runmake test)
  • Documentation has been updated to reflect changes, if applicable
  • Changes are added to the changelog

…ices from the request url to the body of the request when size is larger than 4096 bytes.
@simonvb00simonvb00 changed the titleAdded support for searching large amount of indices by moving the ind…Added support for searching large amount of indicesJul 16, 2025
StijnCaerts
StijnCaerts previously approved these changesJul 16, 2025
Copy link
Collaborator

@StijnCaertsStijnCaerts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work, I think this will be a useful fix for large catalogs, especially now that people are looking for ways to limit searches to certain collections based on authorizations (#409).

StijnCaerts
StijnCaerts previously approved these changesJul 17, 2025
…ort for large amount of queries to ElasticSearch database logic.
Copy link
Collaborator

@jonhealy1jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work!

@jonhealy1jonhealy1 merged commit90fd9ca intostac-utils:mainJul 18, 2025
15 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jonhealy1jonhealy1jonhealy1 approved these changes

@StijnCaertsStijnCaertsStijnCaerts left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@simonvb00@StijnCaerts@jonhealy1

[8]ページ先頭

©2009-2025 Movatter.jp