- Notifications
You must be signed in to change notification settings - Fork106
WIP Android-specific tests for WorkStealingDispatcher.#1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
zach-klippenstein wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Validates behavior with `Dispatchers.Main` and `.immediate`.This can't be merged as-is, since it requires the tests to live in theandroid source set but that's in a different module so it can't seeWSD. Need to land#1370first.
| @@ -38,7 +38,7 @@ import kotlin.coroutines.resume | |||
| * delegate scheduling behavior to. This can either be a confined or unconfined dispatcher, and its | |||
| * behavior will be preserved transparently. | |||
| */ | |||
| internal open class WorkStealingDispatcher protected constructor( | |||
| public open class WorkStealingDispatcher protected constructor( | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- Undo this
Comment on lines -3 to +5
| internal actual typealias Lock = Any | ||
| public actual typealias Lock = Any | ||
| internal actual inline fun <R> Lock.withLock(block: () -> R): R = synchronized(this, block) | ||
| public actual inline fun <R> Lock.withLock(block: () -> R): R = synchronized(this, block) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- Undo this
Comment on lines -3 to +5
| internal expect class Lock() | ||
| public expect class Lock() | ||
| internal expect inline fun <R> Lock.withLock(block: () -> R): R | ||
| public expect inline fun <R> Lock.withLock(block: () -> R): R |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
- Undo this
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates behavior with
Dispatchers.Mainand.immediate.This can't be merged as-is, since it requires the tests to live in the android source set but that's in a different module so it can't see WSD. Need to land#1370 first.