- Notifications
You must be signed in to change notification settings - Fork9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Bump CI build from JDK 19 to 21 (LTS)#8159
Conversation
Secretly hoping it fixeshttps://github.com/square/okhttp/actions/runs/7313047455/job/19924201870 and we get off to the new year with clean builds. |
| @@ -560,7 +561,8 @@ open class HttpUrlTest { | |||
| ']'.code | |||
| ) | |||
| .override( | |||
| Encoding.IDENTITY, | |||
| // java.net.URL got stricter | |||
| if (PlatformVersion.majorVersion >= 21) Encoding.SKIP else Encoding.IDENTITY, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@swankjesse I'm not sure this is right, is there a better way to make assertions here? That it now fails for URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Lemme attempt a follow-up. I think we need to fix our code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@swankjesse requesting post review. Particularly over how to handle JDK 21 URI strictness. |
Landing to get builds green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
No description provided.