- Notifications
You must be signed in to change notification settings - Fork68
Addsqlite3Worker1Promiser type declarations#54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This is going to need lots of overloads:
|
sqlite3Worker1Promiser type declarationssqlite3Worker1Promiser type declarationsGabrielDelepine commentedFeb 11, 2024
Hi, I wanted to let you know that I am currently working on writing the types. I expect to be in a position to share my work with you in the next few days. |
NoelDeMartin commentedFeb 15, 2024
Hey, I just added some partial types to a project recently. They are not comprehensive by any means, but maybe they can serve to get started or to get some ideas:https://github.com/moodlehq/moodleapp/blob/main/src/types/sqlite-wasm.d.ts |
GabrielDelepine commentedFeb 26, 2024
Hi, |
Note that the messageId is an internal-use property used for dispatching messages between the worker and callbacks. It is hypothetically conceivable for clients to tinker with but no actual use for that comes to mind. FWIW, IMO messageId should be flagged as an opaque type of no interest to clients. |
sameoldlab commentedMay 28, 2024
Hi, I made a PR to merge with this adding most of the |
sameoldlab commentedMay 28, 2024
Also copying over myprogress comment avoid splitting overall progress discussion:
|
Add types for `Sqlite3Worker1Promiser`
Fixes#53