- Notifications
You must be signed in to change notification settings - Fork39
Invalid name generation when using python reserved keywords#89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
QuentinN42 wants to merge5 commits intosqlc-dev:mainChoose a base branch fromEscape-Technologies:main
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…n reserved keywordsSigned-off-by: QuentinN42 <quentin@lieumont.fr>
Signed-off-by: QuentinN42 <quentin@lieumont.fr>
Signed-off-by: QuentinN42 <quentin@lieumont.fr>
…figDictSigned-off-by: QuentinN42 <quentin@lieumont.fr>
Signed-off-by: QuentinN42 <quentin@lieumont.fr>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#88
To fix this issue, here is my proposition:
classreserved keyword byclass_.validate_by_nameto allow us to define the class usingAuthor(class_=...).validate_by_aliasto allow JSON serde.Changes overview
internal/poet/reserved.goto append_to reserved names.internal/gen.go::pydanticNodeto addmodel_config = pydantic.ConfigDictinternal/gen.go::fieldNode:_and addpydantic.Field(...)_Questions / possible issues
make testis it correct ?sqlc v1.28.0tosqlc v1.29.0is this intended ?internal/poet/reserved.goI hardcodedreservedKeywordswe should double check it and check if we want to keep it like that.