- Notifications
You must be signed in to change notification settings - Fork900
FixORDER BY arg parsing in sqlite#3962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
andriygm wants to merge2 commits intosqlc-dev:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+289 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
currently, base behavior works but mixing params like so: -- name: ListAuthorsColumnSortDirection :manySELECT*FROM authorsWHERE id> ?ORDER BY CASE WHEN @order_by='asc' THEN name ENDASC, CASE WHEN @order_by='desc'OR @order_by ISNULL THEN name ENDDESC; produces this incorrect output (question marks in CASE clauses should instead be same variable) -- name: ListAuthorsColumnSortDirection :manySELECT id, name, bioFROM authorsWHERE id> ?ORDER BY CASE WHEN ?='asc' THEN name ENDASC, CASE WHEN ?='desc'OR ? ISNULL THEN name ENDDESC this can still be worked around by using named params in this case. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
sqlccurrently doesn't handle boundORDER BYclauses in sqlite, nor does it have tests for this behavior. This PR attempts for rectify this.Closes#3788.