NotificationsYou must be signed in to change notification settings
Fork900
Star15.6k

fix(sqlite): Removed ToLower in typecast#3860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

giuliano-macedo wants to merge3 commits intosqlc-dev:main

base:main

Choose a base branch

fromgiuliano-macedo:fix-3688

Open

fix(sqlite): Removed ToLower in typecast#3860

giuliano-macedo wants to merge3 commits intosqlc-dev:mainfromgiuliano-macedo:fix-3688

Conversation

Copy link

giuliano-macedo commentedFeb 25, 2025

Fixes#3688 by not callingNewIdentifier(name) inconvertCastExpr because this function was ending up callingstrings.ToLower on the type name resulting in type overrides not matching because the cast type name was always lowerCase and the override was always uppercase ingo_type.go@goInnerType.

Alternatively this issue could by changing this line ingoInnerType:

iforide.DbType!=""&&oride.DbType==columnType&&oride.Nullable!=notNull&&oride.Unsigned== col.Unsigned {

iforide.DbType!=""&&strings.EqualFold(oride.DbType,columnType)&&oride.Nullable!=notNull&&oride.Unsigned== col.Unsigned {

But I don't know if this would be a good idea...

Since we're already here, I've added tests for this specific case of type casts + overrides in sqlite, and refacted a variable inconvertCastExpr becausename could be confused with the column name instead of type name.