Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Feat: throw an exception instead on testInteger & testLong#1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
SharmaNishchay wants to merge4 commits intosqlancer:main
base:main
Choose a base branch
Loading
fromSharmaNishchay:Dark_1

Conversation

SharmaNishchay
Copy link
Contributor

@SharmaNishchaySharmaNishchay commentedMar 30, 2025•
edited
Loading

Closes#1161

@SharmaNishchaySharmaNishchay changed the titleTODO: throw an exception instead on testIntegerTODO: throw an exception instead on testInteger & testLongMar 30, 2025
@SharmaNishchaySharmaNishchay changed the titleTODO: throw an exception instead on testInteger & testLongFeat: throw an exception instead on testInteger & testLongMar 30, 2025
@SharmaNishchay
Copy link
ContributorAuthor

@mrigger The checks are passing. Please review the changes. Thanks!

Copy link

@bhavaniprasad-techbhavaniprasad-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@test
public void testIntegerValidRange() {
Randomly r = new Randomly();
for (int i = 0; i < 100; i++) {
int val = r.getInteger(5, 10);
assertTrue(val >= 5 && val <= 10);
}
}

@bhavaniprasad-tech
Copy link

Add input validation for getInteger() and update corresponding test

  • Added a check in Randomly.getInteger(left, right) to throw IllegalArgumentException when left > right
  • Updated testInteger() in TestRandomly.java to assert this exception
  • Ensures safer and more predictable behavior for invalid input ranges

@SharmaNishchay
Copy link
ContributorAuthor

SharmaNishchay commentedApr 9, 2025•
edited
Loading

Add input validation for getInteger() and update corresponding test

  • Added a check in Randomly.getInteger(left, right) to throw IllegalArgumentException when left > right
  • Updated testInteger() in TestRandomly.java to assert this exception
  • Ensures safer and more predictable behavior for invalid input ranges

I think thetestLong2() method already handles that scenario.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bhavaniprasad-techbhavaniprasad-techbhavaniprasad-tech left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TODO: Add Exception for TestRandomly.java
2 participants
@SharmaNishchay@bhavaniprasad-tech
[8]ページ先頭
©2009-2025 Movatter.jp