- Notifications
You must be signed in to change notification settings - Fork1.1k
Create ESM build#609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Create ESM build#609
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I do not sure that I will understand whole impact on the EMCC modularization, but at least these fixes in the modularization works for me in the Blazor applciation, which is by itself ESM environment.closessql-js#524
kant2002 commentedApr 17, 2025
@lovasoa can you take a look again? |
lovasoa commentedApr 18, 2025
Hi and thank you for the contribution! This looks like this duplicates existing code, doesn't it? Maybe the best place for a fix is inside emscripten itself? |
kant2002 commentedApr 18, 2025
I’m Windows developer by heart. I really would like to help, but because of one my quirk where I love to have native Windows build for everything I may go down to very deep rabbit hole. Given that I have no idea what’s an issue with Emscripten you are mention in comment, my second fear is that go down that route and dont come back. I may pinky swear that I will try that and come back within week, but if not I would appreciate if you merge this as is. Will this work for you? Or maybe you have other ideas how we can solve that? |
I do not sure that I will understand whole impact on the EMCC modularization, but at least these fixes in the modularization works for me in the Blazor applciation, which is by itself ESM environment.
closes#524